* Default value and docstring of org-attach-store-link-p
@ 2020-08-29 4:19 Ihor Radchenko
2020-09-03 10:33 ` Bastien
0 siblings, 1 reply; 3+ messages in thread
From: Ihor Radchenko @ 2020-08-29 4:19 UTC (permalink / raw)
To: emacs-orgmode
The default value of org-attach-store-link-p is nil for now.
Would it make more sense to set it to something else (say, 'attach)?
I believe that 'attach or t would be better as a default.
Thoughts?
Also, the docstring does not mention that there may be several different
non-nil values. It is only reflected in the :type field of defcustom.
Best,
Ihor
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Default value and docstring of org-attach-store-link-p
2020-08-29 4:19 Default value and docstring of org-attach-store-link-p Ihor Radchenko
@ 2020-09-03 10:33 ` Bastien
2020-09-03 13:32 ` Ihor Radchenko
0 siblings, 1 reply; 3+ messages in thread
From: Bastien @ 2020-09-03 10:33 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: emacs-orgmode
Hi Ihor,
Ihor Radchenko <yantar92@gmail.com> writes:
> The default value of org-attach-store-link-p is nil for now.
> Would it make more sense to set it to something else (say, 'attach)?
> I believe that 'attach or t would be better as a default.
>
> Thoughts?
I don't have a strong opinion here.
Why do you think it would it be a better as a default?
> Also, the docstring does not mention that there may be several different
> non-nil values. It is only reflected in the :type field of defcustom.
Feel free to propose a patch for this and the suggested switch, we can
apply it after Org 9.4.
Best,
--
Bastien
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Default value and docstring of org-attach-store-link-p
2020-09-03 10:33 ` Bastien
@ 2020-09-03 13:32 ` Ihor Radchenko
0 siblings, 0 replies; 3+ messages in thread
From: Ihor Radchenko @ 2020-09-03 13:32 UTC (permalink / raw)
To: Bastien; +Cc: emacs-orgmode
> I don't have a strong opinion here.
>
> Why do you think it would it be a better as a default?
It seems that other people expect it to be default [1]. Also, I am using
org-attach heavily in my workflows. Most of the time I found myself
inserting the link to attachment right after attaching a file. Finally,
it do not see any drawback adding the link to history vs not adding.
I personally would prefer 'attached as a default, but it is mostly
because I use org-attach already and attach: link would be shorter.
Probably, 'file as default is safer if the user changes the :DIR:
property for some reason.
[1] https://www.reddit.com/r/emacs/comments/ihzh9r/orgmode_quicker_way_to_create_link_to_attachment/
> Feel free to propose a patch for this and the suggested switch, we can
> apply it after Org 9.4.
I will add it to my todo list. This should be lower priority than org-fold.el
Best,
Ihor
Bastien <bzg@gnu.org> writes:
> Hi Ihor,
>
> Ihor Radchenko <yantar92@gmail.com> writes:
>
>> The default value of org-attach-store-link-p is nil for now.
>> Would it make more sense to set it to something else (say, 'attach)?
>> I believe that 'attach or t would be better as a default.
>>
>> Thoughts?
>
> I don't have a strong opinion here.
>
> Why do you think it would it be a better as a default?
>
>> Also, the docstring does not mention that there may be several different
>> non-nil values. It is only reflected in the :type field of defcustom.
>
> Feel free to propose a patch for this and the suggested switch, we can
> apply it after Org 9.4.
>
> Best,
>
> --
> Bastien
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-03 13:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-29 4:19 Default value and docstring of org-attach-store-link-p Ihor Radchenko
2020-09-03 10:33 ` Bastien
2020-09-03 13:32 ` Ihor Radchenko
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).