From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id OHJjH/MDdF9fCAAA0tVLHw (envelope-from ) for ; Wed, 30 Sep 2020 04:05:07 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id gOtQG/MDdF9xHAAA1q6Kng (envelope-from ) for ; Wed, 30 Sep 2020 04:05:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B1E6A940105 for ; Wed, 30 Sep 2020 04:05:05 +0000 (UTC) Received: from localhost ([::1]:41682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNTMU-0003cS-Sx for larch@yhetil.org; Wed, 30 Sep 2020 00:05:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNTM1-0003cJ-6H for emacs-orgmode@gnu.org; Wed, 30 Sep 2020 00:04:33 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:52580) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNTLy-0007Li-IT for emacs-orgmode@gnu.org; Wed, 30 Sep 2020 00:04:32 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id DA2CF8A670; Wed, 30 Sep 2020 00:04:27 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=Akw1nIHAgvIOske3wO7d9h3s6oM=; b=UgrNHH X+LhbwT+GBEjWt+lB2RqHT0Z+bIGUY8X/GdzWTxMWjwu7XVF0i2WrUw2XE6uaDYH CW/j8IOEzIj0HG6eIvWR/3EGhsymX5HquvUseu6CNDZ9ZCbZ58WdaWNauqI12kxP VnQ+osWg3uIk1RGyxvnPfOCU9kO3tUm6hTY6M= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id D2D288A66F; Wed, 30 Sep 2020 00:04:27 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=MOZma5uckvd0/Shb8FH7iW6b4MsVT6gaaU4qOBC/+3Y=; b=Tx3uLAWiykd5tGockjxCa9vLzuFqON78aGRS5uzxSxh/C6P8gUEcm4vUyenHG/AnjdgfipURxqNOmepwN2c9qdAyNLVf526q4CsxeI/D/OzUyfA8d/CHe9y/Cuq8/4otH3GLf1gxeQMqQMPFcY0oW0Gutl01HxJhFGywvF2kdZI= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 618C78A66E; Wed, 30 Sep 2020 00:04:27 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Jarmo Hurri Subject: Re: PATCH: Display point of code block point when confirming evaluation In-Reply-To: <87sglwoata.fsf@iki.fi> References: <87sglwoata.fsf@iki.fi> Date: Wed, 30 Sep 2020 00:04:26 -0400 Message-ID: <87imbvrjud.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 0883AFB2-02D2-11EB-BD01-2F5D23BA3BAF-24757444!pb-smtp2.pobox.com Received-SPF: pass client-ip=64.147.108.71; envelope-from=kyle@kyleam.com; helo=pb-smtp2.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/29 22:12:58 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=UgrNHH X; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=Tx3uLAWi; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: +o+2maRxNS4G Thanks for the patch, and sorry for the very delayed response. Jarmo Hurri writes: > Greetings. > > Please find attached a patch that adds the point of the source code > block to the message shown to user when confirming the evaluation of the > block. > > In large org-files, I have often trouble figuring out which code block > Org is confirming me to evaluate when exporting. This is especially true > when I have set 'cache: yes'. When something changes in code, these > blocks need to be re-evaluated during export, but the '#results:' of > these blocks are not changed. Therefore, on the next export I will be > asked again, unless I find the block and evaluate it by hand myself. > > This patch adds the 'start' element of source block info at the end of > the confirmation message. That sounds reasonable to me, and the change looks fine to me. My only thought is that perhaps the line number would be friendlier to report, but I don't feel strongly about that. I'll wait a few days for any babel users to chime in and then apply (unless you reply that you'd like to reroll it to use line numbers).