emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Kyle Meyer <kyle@kyleam.com>
To: Jarmo Hurri <jarmo.hurri@iki.fi>
Cc: emacs-orgmode@gnu.org
Subject: Re: PATCH: Display point of code block point when confirming evaluation
Date: Wed, 30 Sep 2020 00:04:26 -0400	[thread overview]
Message-ID: <87imbvrjud.fsf@kyleam.com> (raw)
In-Reply-To: <87sglwoata.fsf@iki.fi>

Thanks for the patch, and sorry for the very delayed response.

Jarmo Hurri writes:

> Greetings.
>
> Please find attached a patch that adds the point of the source code
> block to the message shown to user when confirming the evaluation of the
> block.
>
> In large org-files, I have often trouble figuring out which code block
> Org is confirming me to evaluate when exporting. This is especially true
> when I have set 'cache: yes'. When something changes in code, these
> blocks need to be re-evaluated during export, but the '#results:' of
> these blocks are not changed. Therefore, on the next export I will be
> asked again, unless I find the block and evaluate it by hand myself.
>
> This patch adds the 'start' element of source block info at the end of
> the confirmation message. 

That sounds reasonable to me, and the change looks fine to me.  My only
thought is that perhaps the line number would be friendlier to report,
but I don't feel strongly about that.

I'll wait a few days for any babel users to chime in and then apply
(unless you reply that you'd like to reroll it to use line numbers).

next prev parent reply	other threads:[~2020-09-30  4:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-07  7:26 PATCH: Display point of code block point when confirming evaluation Jarmo Hurri
2020-09-30  4:04 ` Kyle Meyer [this message]
2020-09-30  4:57   ` TEC
2020-09-30 16:46     ` Eric S Fraga
2020-10-07  3:37   ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imbvrjud.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=jarmo.hurri@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).