From: Kyle Meyer <kyle@kyleam.com>
To: Robin Campbell Joy <rcj@robinjoy.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ob-sql.el: Add support for SAP HANA
Date: Wed, 17 Mar 2021 00:07:21 -0400 [thread overview]
Message-ID: <87im5qift2.fsf@kyleam.com> (raw)
In-Reply-To: <CADzxVkEZ2Df4di_2PTsV==JmetA76_-wDHwK6sSN11R1hcVdBg@mail.gmail.com>
Robin Campbell Joy writes:
> Subject: [PATCH] ob-sql.el: Add support for SAP HANA
Thanks for the update. Pushed (b241c126b).
> diff --git a/testing/lisp/test-ob-sql.el b/testing/lisp/test-ob-sql.el
[...]
> +
> +(require 'org-test)
> +(require 'ob-sql)
I've dropped these two lines.
For the first one, currently only four test files load org-test
explicitly, while the majority of the tests rely on org-test being
loaded as part of the setup.
For the second, nearly all ob-LANG tests check whether the corresponding
ob- feature is available, signaling missing-test-dependency if it's not.
Which ob- libraries are loaded/tested can then controlled by the
Makefile variable BTEST_OB_LANGUAGES. Explicitly loading the ob- file
goes against that setup, making the (featurep ...) check that follows
always return non-nil,
I'm guessing this line was adjusted from test-ob-sqlite, which appears
to be the one [*] ob-LANG test file that gets this wrong. I've
pushed another commit to adjust it.
[*] I believe ob-emacs-lisp is an intended exception.
> +(unless (featurep 'ob-sql)
> + (signal 'missing-test-dependency "Support for sql code blocks"))
next prev parent reply other threads:[~2021-03-17 4:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 7:55 Robin Campbell Joy
2021-03-10 7:50 ` Robin Campbell Joy
2021-03-16 4:43 ` Kyle Meyer
2021-03-16 15:34 ` Robin Campbell Joy
2021-03-17 4:07 ` Kyle Meyer [this message]
2021-03-16 19:27 ` Daniele Nicolodi
-- strict thread matches above, loose matches on Subject: below --
2021-02-04 7:15 Robin Campbell Joy
2021-02-03 20:56 Robin Campbell Joy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im5qift2.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=emacs-orgmode@gnu.org \
--cc=rcj@robinjoy.net \
--subject='Re: [PATCH] ob-sql.el: Add support for SAP HANA' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).