From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6FZ9Fmu7jWDdDQEAgWs5BA (envelope-from ) for ; Sat, 01 May 2021 22:34:51 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id YOkmEmu7jWAeGAAAB5/wlQ (envelope-from ) for ; Sat, 01 May 2021 20:34:51 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BA5EC193D4 for ; Sat, 1 May 2021 22:34:50 +0200 (CEST) Received: from localhost ([::1]:39858 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcwK9-0006lK-Px for larch@yhetil.org; Sat, 01 May 2021 16:34:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33560) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcwIB-0005X1-As for emacs-orgmode@gnu.org; Sat, 01 May 2021 16:32:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49580) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcwI9-0001NN-5Q; Sat, 01 May 2021 16:32:45 -0400 Received: from [78.194.183.21] (port=52014 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1lcwI7-0000cu-Nj; Sat, 01 May 2021 16:32:44 -0400 Received: by guerry (Postfix, from userid 1000) id CA6841A60E96; Sat, 1 May 2021 22:32:41 +0200 (CEST) From: Bastien To: =?utf-8?Q?S=C3=A9bastien?= Miquel Subject: Re: [PATCH] ob-tangle.el: Speed up tangling In-Reply-To: (=?utf-8?Q?=22S=C3=A9bastien?= Miquel"'s message of "Sat, 1 May 2021 20:13:10 +0000") Organization: GNU References: <57480e77-024a-adcc-ec9a-c20b84ac762a@posteo.eu> <9dfb44d3-0c4a-6a66-0efa-c70e9434ee5e@posteo.eu> <87a6pe4hj1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Sat, 01 May 2021 22:32:41 +0200 Message-ID: <87im42w5xy.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode , mail@nicolasgoaziou.fr Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619901290; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=VgVXFhspGaxm+UUe6CJ5Cuf8QdGwRYogg2J0gLtf5Jw=; b=jAo2szocSuqlM9mz7lHTjXYC9j6Y917KISA7qICqQFnEv6JsnU2iujgdeNfCgTZ0Fh3U0e 8ujNYuUwsTPf3aUkAolqKdhz/0cp7aws4XG9eLrr1v+R62Zxx97N7gdKnbvpVmgIY/imRM tmYbEteVWsLEUmd1a+k9XN5VC9+bCRrvnAwSDxjdfJvYInhwpt7FBBan8+900RbRWHHNh2 MwyKhv52NKvcCS/78v3zsDItqRJMZP/HIX9sVdsJ2J0iFoTuQZ6cgmgSFk0sM9ueq7Cngb K3M5jDkUq/L8laZVXNsEH2VGPhzArRy0+/Es9Eki9sB/P0cWCRlEbdzgth5STw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619901290; a=rsa-sha256; cv=none; b=f2lH/WwfW1C96wa16QrRCgo7SbrCx5x6GWFRCUrtaOFJ2hoJ0Bz+h3y1nOVuwtnCxzxHUT i6ktPeRyv8x19w0B18kU6973Sm2PqtnExX9Yt/OCV5Iv3FcPpHTck2JnQimUUlz2iwWJN1 VtgtfFDmjPlOh7IPMY6iRh9pkvM5ww09PyWq5hs8SnPV67n0ogyd91IPe39ViQKxnpl544 raZnyNC6h/NNGGDWYrS86yOVpjSuphD9gzWJ0q75B+9IEHN0vS05emKrh38TO84H6Attg9 +mboNPIWVOagi9NXW0iZmuHEbsaC9BfiaivsDEX+6BzCfxdsN8drpwpQwDRt0Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.96 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: BA5EC193D4 X-Spam-Score: -2.96 X-Migadu-Scanner: scn0.migadu.com X-TUID: BGu5UykMj/50 Hi S=C3=A9bastien, S=C3=A9bastien Miquel writes: > Indeed, I hadn't thought to run the tests, sorry. I've fixed my code > and modified the `block-order` test in order for it to pass. Applied with commit a2cb9b853, thank you very much for the updated patch. > The patch does modify the order of the tangled blocks. When several > blocks with different languages are tangled to the same file, they > used to be grouped according to language, and are now tangled in the > order in which they appear. I assumed this was an oversight in the > previous code, but since this test exists, maybe it was intended ? > > Nicolas Goaziou wrote this test, perhaps he could comment on this. Sure, feel free to adapt the code further if needed after discussing this. Thanks, --=20 Bastien