From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wLV+Lg1ALmEkKgEAgWs5BA (envelope-from ) for ; Tue, 31 Aug 2021 16:43:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cOpDKg1ALmHASgAA1q6Kng (envelope-from ) for ; Tue, 31 Aug 2021 14:43:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2FFF8166C5 for ; Tue, 31 Aug 2021 16:43:25 +0200 (CEST) Received: from localhost ([::1]:41290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mL4yx-00081E-Kt for larch@yhetil.org; Tue, 31 Aug 2021 10:43:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mL4xM-00080J-UU for emacs-orgmode@gnu.org; Tue, 31 Aug 2021 10:41:45 -0400 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]:37538) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mL4xB-0006YC-Uy for emacs-orgmode@gnu.org; Tue, 31 Aug 2021 10:41:44 -0400 Received: by mail-pf1-x434.google.com with SMTP id x19so8128084pfu.4 for ; Tue, 31 Aug 2021 07:41:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:references:user-agent:in-reply-to :message-id:mime-version; bh=KEMZf/BAexhIHdPKlOKoFDlTF5iv+USCl4adlxwddPQ=; b=vYTEco0gh03Cl3NaHGkev3IuA/XDVn91zwahLNM3RBHc6lqguFE5ywSjQK6+WGMGFF DRRpg+hZnuMEO9RhV4M9SqH4HZcmkcnFdSL/7fbIGLBgI6Zm3VfmpMEZq8vSSL6RF9DT uzwZ/+6gjORYu01Kbk/YC+ryGDwzHXkCHk3f+4eYknSecQazUn32dW+4K7OZ1r8IqpAW 2TIIf/qjHnQ8mEYiS/kdNzOLhh8AD7hJSSUtjzwq1VkQvgNH3AQdZd7+sNboG5WJDXU1 0tOl/jhhwidnjvJDTuQd9W2p7rlrim9ANAfU7peppd8/UrHJoTgqw6RHvC3R1BuzC604 n0HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:references:user-agent :in-reply-to:message-id:mime-version; bh=KEMZf/BAexhIHdPKlOKoFDlTF5iv+USCl4adlxwddPQ=; b=rCOcLf0LncGGcJbDqWtMbt645MmxrhAsP3tkqfCgHf2X6iFeQw+wP/Tqha+bGlPtAy 44legRedtGBPkKTVdGmCaGZfSjN/pDCzcD8wMkM2Ja8uZUyxSmwLZR9cQ3wMiKnROayk O44DkhqJhkv5BktvA0L0P1+lcZcTHcz0fL8EUQBDeYquLMnAMQ+F1Ej23Fi/8164ibs7 jU9S/Uo6XdXkYeOvzhuLK0a8KTzGqXw3ISZog04sUCY64B4jlkuqxREHUsJBGw1I0cqT c8nNjrNnEFN8rc//SuXgP8/4va8d8zOvTc5Hfd9n+bnQ9X+tkUj84t1ppdjVzIOzwQVu rnVw== X-Gm-Message-State: AOAM532jU2GSEgihSt7YyAvdDif+fcXzyOC/YowDA7y5mZJsGwuRzAsv bBxuYKI+fTMtPKDHnSdG+SI= X-Google-Smtp-Source: ABdhPJxrNMlm8Cg9ANGF1GiUMsTmzcPRaDYOWzg6EW4XQu1HXngB64ALYF+nF9hQqmeWcYCHNtaXyQ== X-Received: by 2002:a65:6894:: with SMTP id e20mr26617572pgt.419.1630420892194; Tue, 31 Aug 2021 07:41:32 -0700 (PDT) Received: from localhost (61-245-128-160.3df580.per.nbn.aussiebb.net. [61.245.128.160]) by smtp.gmail.com with ESMTPSA id u17sm17818614pfh.184.2021.08.31.07.41.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 07:41:31 -0700 (PDT) From: Timothy To: Nick Dokos Subject: Re: [PATCH] Fix match/maxlevel conflict in colview dynblock Date: Tue, 31 Aug 2021 22:33:47 +0800 References: <87h7h0w5nz.fsf@alphaville.usersys.redhat.com> User-agent: mu4e 1.6.5; emacs 28.0.50 In-reply-to: <87h7h0w5nz.fsf@alphaville.usersys.redhat.com> Message-ID: <87ilzloew7.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=tecosaur@gmail.com; helo=mail-pf1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630421005; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=KEMZf/BAexhIHdPKlOKoFDlTF5iv+USCl4adlxwddPQ=; b=Q66K5z5VTiwuZLMR5msGolU7RCHgXZ2y1Fq0Xk5uwHFzm763YzBK7iCCn1t8hefsJCAyEu 3BBvlvmyIxifaPp8IFMgp2Z2lfjNxoq1drF1bvS9d9eVTOj+rA0f4sIEZjT716PJ24B2E3 c/Zk4jmXgOaLvPF7Fe7knPLRxVLx2OLjCCAP1wyK+WxucI1km0m/aaBcNHleKpGIGsxcwv oENtB0GRPiEWyG7OPMeUdnijEEH69bd9BBNQCsFZPn/FHLWaD+SYy5/NktOQfRgHpYJLEz +wDspBAoRRn4PDE8pYjYk6sVLIZzkBrCZYQHK0CjqKeUH7w1k3zmWNI1YbUjRw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630421005; a=rsa-sha256; cv=none; b=VRUEYUAUcFMoJ3rWwR4hbnRGC3usI2m+U0C5zPgJQfJbuY/0yewpH0lTQtRPiuk95845LG P8NWKMk6P8jfJmF77dy8L77QmH9F59V8oaSnRmtvSWoeJqkYe/5i7EQzmEoFWS6TbfGjua CVT0SkE8GeXO1Ae3gjW8JOuKfQhlNj6XrFphJpPcUEHb7ukt7effHOa1PawV18siaGdNKi bKu0DkJcBSvcbi3Lvkd305MUeRYjovz0ElU2YJSA8sa2x0o4011HIoeD21wDeOfICsP+Lt t6ZrAtQcls1ki1Zw4DvbZsilacHH3fqhm0t5Zyqm1BgbeW5av6GUReTlSMtJvg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=vYTEco0g; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -0.62 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=vYTEco0g; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 2FFF8166C5 X-Spam-Score: -0.62 X-Migadu-Scanner: scn0.migadu.com X-TUID: HJbR6t3PV7dO --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Nick, Thanks for reporting this issue here, and providing a patch. Unfortunately = the =E2=80=9Cmain maintainers=E2=80=9D seem to be rather busy as of late, leavi= ng you hanging for quite a while. I=E2=80=99ve had a look at the issue and your patch, and it = the issue seems clear, and your patch small and straightforward enough that I feel confident pushing it should be fine :) it=E2=80=99s now on master with a sm= all tweak to the commit message. Thanks for your efforts. > Specifying both `maxlevel=E2=80=99 and `match=E2=80=99 in a columnview dy= namic block > was broken: the `match=E2=80=99 argument is ignored in that case. See the= link > below for a (not so minimal) ECM. > > Reported-by: Pablo A Perez-Fernandez > Link: > > =E2=80=93 > Nick > > =E2=80=9CThere are only two hard problems in computer science: cache > invalidation, naming things, and off-by-one errors.=E2=80=9D -Martin Fowl= er > > From 8bcff482e59c24758f87b9b5cdef3bc123dc12f8 Mon Sep 17 00:00:00 2001 > From: Nick Dokos > Date: Sun, 11 Jul 2021 22:30:22 -0400 > Subject: [PATCH] Fix match/maxlevel conflict in colview dynblock > > * lisp/org-coplview.el (org-columns=E2=80=93capture-view): Combine the ma= tch > and maxlevel arguments properly to construct the MATCH argument of > `org-map-entries=E2=80=99. > > Specifying both `maxlevel=E2=80=99 and `match=E2=80=99 in a columnview dy= namic block > does not work: the `match=E2=80=99 argument is ignored in that case. See = the > link below for a (not so minimal) ECM. > > Reported-by: Pablo A Perez-Fernandez > Link: > =E2=80=94 > lisp/org-colview.el | 5 +++=E2=80=93 > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff =E2=80=93git a/lisp/org-colview.el b/lisp/org-colview.el > index 2e1c29a99..7144308ff 100644 > =E2=80=94 a/lisp/org-colview.el > +++ b/lisp/org-colview.el > @@ -1398,8 +1398,9 @@ other rows. Each row is a list of fields, as strin= gs, or > (org-get-tags)))) > (push (cons (org-reduced-level (org-current-level)) (nreverse row)) > table))))) > - (or (and maxlevel (format =E2=80=9CLEVEL<=3D%d=E2=80=9D maxlevel)) > - (and match match)) > + (if match > + (concat match (and maxlevel (format =E2=80=9C+LEVEL<=3D%d=E2=80= =9D maxlevel))) > + (and maxlevel (format =E2=80=9CLEVEL<=3D%d=E2=80=9D maxlevel))) > (and local =E2=80=99tree) > =E2=80=99archive =E2=80=99comment) > (org-columns-quit) All the best, Timothy --=-=-=--