emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [oc-basic] fontification weirdness
@ 2021-11-24 20:32 Bruce D'Arcus
  2021-11-24 21:57 ` Nicolas Goaziou
  0 siblings, 1 reply; 5+ messages in thread
From: Bruce D'Arcus @ 2021-11-24 20:32 UTC (permalink / raw)
  To: org-mode-email

I can't fully pin this down, but I and a couple of others I've
discussed this with are seeing the following behavior.

With this example:

a citation [cite:@couper2014] and another [cite:@kohn2006]

... the first citation is highlighted, and the second (and any
subsequent) is not.

In some way I can't reproduce, I can then get the fontification to
work correctly, but if I restart, the problem reappears.

Discussed more here:

https://github.com/bdarcus/citar/discussions/430#discussioncomment-1693707

Can anyone else confirm this?

Bruce


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [oc-basic] fontification weirdness
  2021-11-24 20:32 [oc-basic] fontification weirdness Bruce D'Arcus
@ 2021-11-24 21:57 ` Nicolas Goaziou
  2021-11-25 13:11   ` Bruce D'Arcus
  0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2021-11-24 21:57 UTC (permalink / raw)
  To: Bruce D'Arcus; +Cc: org-mode-email

Hello,

"Bruce D'Arcus" <bdarcus@gmail.com> writes:

> I can't fully pin this down, but I and a couple of others I've
> discussed this with are seeing the following behavior.
>
> With this example:
>
> a citation [cite:@couper2014] and another [cite:@kohn2006]
>
> ... the first citation is highlighted, and the second (and any
> subsequent) is not.
>
> In some way I can't reproduce, I can then get the fontification to
> work correctly, but if I restart, the problem reappears.
>
> Discussed more here:
>
> https://github.com/bdarcus/citar/discussions/430#discussioncomment-1693707
>
> Can anyone else confirm this?

I couldn't reproduce it, but I saw something fishy in the fontification
code. I fixed it. Hopefully, your problem is gone, too. Crossing
fingers.

Regards,
-- 
Nicolas Goaziou


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [oc-basic] fontification weirdness
  2021-11-24 21:57 ` Nicolas Goaziou
@ 2021-11-25 13:11   ` Bruce D'Arcus
  2021-11-26 10:48     ` Nicolas Goaziou
  0 siblings, 1 reply; 5+ messages in thread
From: Bruce D'Arcus @ 2021-11-25 13:11 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: org-mode-email

On Wed, Nov 24, 2021 at 4:57 PM Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>
> Hello,
>
> "Bruce D'Arcus" <bdarcus@gmail.com> writes:
>
> > I can't fully pin this down, but I and a couple of others I've
> > discussed this with are seeing the following behavior.
> >
> > With this example:
> >
> > a citation [cite:@couper2014] and another [cite:@kohn2006]
> >
> > ... the first citation is highlighted, and the second (and any
> > subsequent) is not.
> >
> > In some way I can't reproduce, I can then get the fontification to
> > work correctly, but if I restart, the problem reappears.
> >
> > Discussed more here:
> >
> > https://github.com/bdarcus/citar/discussions/430#discussioncomment-1693707
> >
> > Can anyone else confirm this?
>
> I couldn't reproduce it, but I saw something fishy in the fontification
> code. I fixed it. Hopefully, your problem is gone, too. Crossing
> fingers.

I haven't yet had a chance to test the latest commit, but another user
did and reported:

"I have what I think is this commit (b3cc2f793, the latest one as of
right now) and the above bug still happens for me."

-----------
His explanation of that bug, which I can reproduce on my end:

I can replicate this behaviour with two citations on one line, but
only when the first citation is a valid reference key:

[cite:@Sno1959:TwoCultures] [cite:@Snow]

Just changing one character in the first citation key causes the
second to flip between being highlighted or not.
-------------

So to be clear:

Two citations on one line.

If both keys are valid, the second one is not highlighted.

If I change the first key so it is invalid, both are then highlighted.

Can you reproduce that?

Bruce


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [oc-basic] fontification weirdness
  2021-11-25 13:11   ` Bruce D'Arcus
@ 2021-11-26 10:48     ` Nicolas Goaziou
  2021-11-27  1:12       ` Bruce D'Arcus
  0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2021-11-26 10:48 UTC (permalink / raw)
  To: Bruce D'Arcus; +Cc: org-mode-email

Hello,

"Bruce D'Arcus" <bdarcus@gmail.com> writes:

> I haven't yet had a chance to test the latest commit, but another user
> did and reported:
>
> "I have what I think is this commit (b3cc2f793, the latest one as of
> right now) and the above bug still happens for me."
>
> -----------
> His explanation of that bug, which I can reproduce on my end:
>
> I can replicate this behaviour with two citations on one line, but
> only when the first citation is a valid reference key:
>
> [cite:@Sno1959:TwoCultures] [cite:@Snow]
>
> Just changing one character in the first citation key causes the
> second to flip between being highlighted or not.
> -------------
>
> So to be clear:
>
> Two citations on one line.
>
> If both keys are valid, the second one is not highlighted.
>
> If I change the first key so it is invalid, both are then highlighted.
>
> Can you reproduce that?

I reproduced it on a fresh Emacs. IIUC, it stemmed from the fact that
fontification required "ox.el" to be loaded beforehand.

It should now be fixed. Thanks.

Regards,
-- 
Nicolas Goaziou


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [oc-basic] fontification weirdness
  2021-11-26 10:48     ` Nicolas Goaziou
@ 2021-11-27  1:12       ` Bruce D'Arcus
  0 siblings, 0 replies; 5+ messages in thread
From: Bruce D'Arcus @ 2021-11-27  1:12 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: org-mode-email

On Fri, Nov 26, 2021 at 5:48 AM Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:

> It should now be fixed. Thanks.

Confirmed; thanks!

Bruce


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-11-27  1:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-24 20:32 [oc-basic] fontification weirdness Bruce D'Arcus
2021-11-24 21:57 ` Nicolas Goaziou
2021-11-25 13:11   ` Bruce D'Arcus
2021-11-26 10:48     ` Nicolas Goaziou
2021-11-27  1:12       ` Bruce D'Arcus

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).