From: Ihor Radchenko <yantar92@gmail.com>
To: Bastien Guerry <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: Drop defadvice from Org
Date: Thu, 07 Apr 2022 12:11:14 +0800 [thread overview]
Message-ID: <87ilrl7ct9.fsf@localhost> (raw)
In-Reply-To: <87y20pmjo9.fsf@gnu.org>
Bastien Guerry <bzg@gnu.org> writes:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> The patch below gets rid of the old `defadvice`, replacing it with
>> `advice-add`.
>
> Applied in the main branch as 6d73cd34a, thanks a lot!
The change in (eval ...) call inside org-diary-sexp-entry broke sexp
timestamps. See orgmode.org/list/875ynnojvf.fsf@localhost
I think that calendar-related evals should be reverted to use dynamic
scope. AFAIU, diary staff is relying on dynamic scope and cannot be used
with lexical.
Best,
Ihor
next prev parent reply other threads:[~2022-04-07 4:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <jwv8rtpptrk.fsf-monnier+emacs@gnu.org>
[not found] ` <jwvpmn1od82.fsf-monnier+emacs@gnu.org>
[not found] ` <87a6drnsv6.fsf@gnu.org>
[not found] ` <jwvo827au9m.fsf-monnier+emacs@gnu.org>
[not found] ` <87a6dq46kd.fsf@gnu.org>
2022-03-31 17:55 ` Drop defadvice from Org Stefan Monnier
2022-03-31 23:17 ` Samuel Wales
2022-03-31 23:59 ` Stefan Monnier
2022-04-01 6:29 ` Samuel Wales
2022-04-01 13:20 ` Stefan Monnier
2022-04-01 5:55 ` Bastien Guerry
2022-04-07 4:11 ` Ihor Radchenko [this message]
2022-04-07 13:09 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilrl7ct9.fsf@localhost \
--to=yantar92@gmail.com \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).