From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id QMA0IL2BOWSzgAEASxT56A (envelope-from ) for ; Fri, 14 Apr 2023 18:39:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id eHwiIL2BOWQwXgAAauVa8A (envelope-from ) for ; Fri, 14 Apr 2023 18:39:25 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3B81C3639D for ; Fri, 14 Apr 2023 18:39:25 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pnMRQ-00053J-Lq; Fri, 14 Apr 2023 12:38:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnMRO-00053B-Sy for emacs-orgmode@gnu.org; Fri, 14 Apr 2023 12:38:27 -0400 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pnMRN-0000kI-3N for emacs-orgmode@gnu.org; Fri, 14 Apr 2023 12:38:26 -0400 Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-63b68f53fabso175268b3a.0 for ; Fri, 14 Apr 2023 09:38:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681490301; x=1684082301; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=hIENTa7L9XhkNEUACgTQ8DZ565Pq8ECEQ7dhxxO2rsY=; b=ITyTAuve1Mv5i0baQ0bryUCTwvl15+/aNwM23/zFHYBXkUofdeB19c1wHWVjEXOmc4 uKhfxLy4HwrctXvyL3Bloz/QzUZX9JjC3Zn74MtPO/53uRz7wNCrz3/whu6ukIHzqraj A3rDapr56s4ebGAG17KhG1XwX9tfewccPGCNLSLi51Ri8Z1M8dXnn1lzVyWiquLvjwH4 iC8g2LZ53wLtVNEg4OwTyCL8Q7XMKKQo3jrj4sqSbPF0jIvdi/kGeyPI76wPS/4tjwZt eeozKx79cYwlB5VrEhbzp/dRnu6fTWvBErFdDXMwsYhewTMlzASHbda8EUaR2FQTWFfB T7vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681490301; x=1684082301; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hIENTa7L9XhkNEUACgTQ8DZ565Pq8ECEQ7dhxxO2rsY=; b=adjSQoxnezYKn9VsEXfAauPV0NxE8vZ9E9RCoXYKoyGf7jskDWGShkMKUCn4VDUEOO SScQvBhTHH1ve918DS0oZvOV0j83jYZHeIFCd+YflO21EwtaiUB26rBp+jZUSSwx/RS5 mf+t7krPJfg4T98DtdUf+Nj/EphfQAuHoICOyQT/lEM/PiXSmm/5lcAilXImZXupaB9T TIxV6pwF6wQiNZiOHZxCWxqvMJ8j+Vqbai+P79FlE36X00Fek15hbdtCEaI3uxu5SQw0 kPGJCkwpSChu+x67Cyu+kLVX7xhHz7dEIzQ++jks21p7WUSL7u27+VTMoWxO7FUml0z+ JxOg== X-Gm-Message-State: AAQBX9cjNZukjsl0uwHyqOBv/jiXlyQI7i1AnYgDOZIh6fK0CXKmQ1hY 4ZPsBN0mjuA1JdsL1YN1OsU= X-Google-Smtp-Source: AKy350ZZddLFtfJqN94hXgAXX8F5OVYQxotais0engFYQ9gTX0KkPt+7cMFdaK0RMH7w3oK20o4KWQ== X-Received: by 2002:a05:6a00:8c6:b0:638:13ab:b0a9 with SMTP id s6-20020a056a0008c600b0063813abb0a9mr9783856pfu.24.1681490300812; Fri, 14 Apr 2023 09:38:20 -0700 (PDT) Received: from localhost (157-131-78-143.fiber.dynamic.sonic.net. [157.131.78.143]) by smtp.gmail.com with ESMTPSA id p15-20020aa7860f000000b005810c4286d6sm3284030pfn.0.2023.04.14.09.38.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Apr 2023 09:38:19 -0700 (PDT) From: Jack Kamm To: tomas@tuxteam.de, Ihor Radchenko Cc: "Stephen J. Eglen" , emacs-orgmode@gnu.org, mail@nicolasgoaziou.fr, steuer@hsu-hh.de Subject: Re: Bug report for ox-icalendar: newlines should be CRLF In-Reply-To: References: <87ilgljv6i.fsf@localhost> <875yaej9sa.fsf@gmail.com> <87wn2en543.fsf@localhost> Date: Fri, 14 Apr 2023 09:38:18 -0700 Message-ID: <87ildyberp.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::433; envelope-from=jackkamm@gmail.com; helo=mail-pf1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1681490365; a=rsa-sha256; cv=none; b=M3aFNHWl/AyC8gZF4S7fWW6QFfW5EePjO+q/VmGRm2cdSTuTae0sH9xg9zJj/LOfKxB2r/ 4N5MA/Tlh/o56B7SlsybBbhLhlKkPGEdOK2EF/gnXtI5oqt1142ZfjdV9Umn+fkvKIqued qTeTWFT1RwAAU5wFixB14HMIVMM0ZcL8VVRIw7x4By6VfrZhibO9vg6OKqTi54vY9xplVj z/l4+24PEeXRrounGZVJMqfs74+ZVqM02AtNvHW1qBBMV8BKlgRcJQMiFDWMiZpymEVnfs JCmsGpZJL2X8ALJH8rYvy3HmDEIju5cJdfBm9NTFZ7Q3Lkaik/asG3DVlPvufQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ITyTAuve; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1681490365; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=hIENTa7L9XhkNEUACgTQ8DZ565Pq8ECEQ7dhxxO2rsY=; b=u+VXc3FNtnuIo0TaIlesyPJr8wOE6fiKXG1ZqfTdpfRKM8jKG0IFrv0+aaUuFK8f03Rc7l CAsYL7AVIfa7U5Ysh8YAc4hpd+MPJOXT2+RLl2OgV8Wtf9+2ClB9McW2ZefNQuJA9BeKwG v5Ssx+oBaeeKNPeow9ZAczKPM8vMys0pSFyPKn5ZyojTxaD9r7rip/tQN/uGHrMKGf5o8m hArtxiemIPOM3m2f5DQuhjZZm5lLTLFQv2rZg9zHCQaL62gB6aFyddRzkR2Q8U5eBoRkVD IJPc8ZkKBUf6ejUYu7izhteheuzY7u7W3W80PoJv49hBonDcDLSjdWkp8WkmsQ== X-Migadu-Queue-Id: 3B81C3639D Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ITyTAuve; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -8.45 X-Spam-Score: -8.45 X-TUID: YgHI3gGvE2yp writes: >> > There is a related issue about EOLs, not just \r\n -- each line should >> > be a maximum of 75 characters; this is handled by >> > org-icalendar-fold-string >> >> May you please provide a link to the iCalendar spec document section >> describing this requirement? > > It's in rfc5545 [1], referenced to from rfc7986 [2]. Since VEVENT and VTODO are wrapped in `org-icalendar-fold-string', I think the only place this error may occur is in the preamble created by `org-icalendar--vcalendar', e.g. in PRODID, X-WR-CALDESC, etc. The fix is to move the call to `org-icalendar-fold-string' out of org-icalendar--vevent/vtodo, and instead put it in `org-icalendar--vcalendar'. Then the line folding will apply to the whole VCALENDAR instead of just the VTODO and VEVENT. An earlier version of my CRLF patch actually did something like this. I can push such a fix over the weekend. Let me know if you'd rather I send the patch for review here first.