From: Ihor Radchenko <yantar92@posteo.net>
To: "Valentin Herrmann via General discussions about Org-mode."
<emacs-orgmode@gnu.org>
Cc: Valentin Herrmann <me@valentin-herrmann.de>
Subject: Re: [PATCH] org.el: Respect org-extend-today-until in timestamps with ++
Date: Sun, 13 Aug 2023 12:21:59 +0000 [thread overview]
Message-ID: <87il9jf7yw.fsf@localhost> (raw)
In-Reply-To: <20230813091806.1435284-1-me@valentin-herrmann.de>
Valentin Herrmann via "General discussions about Org-mode."
<emacs-orgmode@gnu.org> writes:
> * org.el (org-auto-repeat-maybe): Changed org-auto-repeat-maybe, so that
> switching a repeating todo with a timestamp of the form <… ++…> respects
> `org-extend-today-until'.
Thanks, this would make sense. However, I have comments on your patch.
> - (nshift 0))
> + (nshift 0)
> + (time-to-extend (seconds-to-time (* 3600 org-extend-today-until))))
This will return time since epoch:
(format-time-string "%x %X" (seconds-to-time (* 3600 org-extend-today-until)))
;; => "01/01/1970 06:00:00 AM"
> (while (or (= nshift 0)
> - (not (time-less-p nil time)))
> + (not (time-less-p nil (time-add time-to-extend time))))
And this compares "now" with year 1970. Will always return nil.
It would make things easier if you added a test for this fix into
`test-org/auto-repeat-maybe' in testing/lisp/test-org.el
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-08-13 12:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-13 9:18 [PATCH] org.el: Respect org-extend-today-until in timestamps with ++ Valentin Herrmann via General discussions about Org-mode.
2023-08-13 12:21 ` Ihor Radchenko [this message]
2023-08-13 12:44 ` Ihor Radchenko
2023-08-13 13:21 ` Valentin G. J. Herrmann via General discussions about Org-mode.
2023-08-13 14:01 ` Valentin G. J. Herrmann via General discussions about Org-mode.
2023-08-13 14:17 ` Ihor Radchenko
[not found] ` <89628d3e-5feb-a764-0bc4-ace385de7c80@valentin-herrmann.de>
[not found] ` <87a5uuq6s5.fsf@localhost>
[not found] ` <11240b6c-0017-0116-75bd-31eb052f42ab@valentin-herrmann.de>
2023-08-14 12:51 ` Ihor Radchenko
2023-08-14 14:01 ` Valentin G. J. Herrmann via General discussions about Org-mode.
2023-08-14 15:18 ` Ihor Radchenko
2023-08-14 16:22 ` Bastien Guerry
-- strict thread matches above, loose matches on Subject: below --
2023-08-13 8:27 Valentin Herrmann via General discussions about Org-mode.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il9jf7yw.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=me@valentin-herrmann.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).