From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Entities Date: Wed, 23 May 2012 23:53:39 +0200 Message-ID: <87hav68syk.fsf@gmail.com> References: <4FA9DBFA.8080405@kli.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([208.118.235.92]:49623) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXJXs-0001qX-Qw for emacs-orgmode@gnu.org; Wed, 23 May 2012 17:56:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXJXq-0001Kj-OV for emacs-orgmode@gnu.org; Wed, 23 May 2012 17:56:40 -0400 Received: from mail-we0-f169.google.com ([74.125.82.169]:39733) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXJXq-0001KQ-GG for emacs-orgmode@gnu.org; Wed, 23 May 2012 17:56:38 -0400 Received: by wefh52 with SMTP id h52so6501217wef.0 for ; Wed, 23 May 2012 14:56:36 -0700 (PDT) In-Reply-To: <4FA9DBFA.8080405@kli.org> (Mark E. Shoulson's message of "Tue, 08 May 2012 22:52:42 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "Mark E. Shoulson" Cc: org-mode mailing list Hello, "Mark E. Shoulson" writes: > There's a small bug in rendering the entities when org-pretty-entities > is on (I get the feeling that org-pretty-entities is not a very > commonly-used feature). The entities \sup1 \sup2 \sup3 and \there4 are > not rendered properly. The regex detecting entities apparently doesn't > catch numbers at the end, except for the special case of fractions. I've > added the others to the special-casing and attach a patch for it; I > hope I managed to include the changelog properly (is git format-patch - > -attach the way to go?). This looks good. You should add a title to your patch, like "Fix detection of entities ending with a number" or "org-entities: Add some entities". Also, please capitalize the word after the colons. > Also attached is another patch that might or might not be useful. > Sometimes it can be a problem when you can't type, say, asterisks > around a word when you NEED asterisks around the word, not a boldface > word (I'd been getting around it by using Unicode characters that look > like asterisks, like =E2=88=97). The way to do it right is to use the \ast > entity, which expands to the right thing but doesn't affect > formatting. There's also already a \tilde entity, to allow putting in > tildes without accidentally setting something verbatim. I added > entities for the remaining markup characters: \plus, \under, \equal, > and \slash. \under might be particularly handy when avoiding > subscripting (which raises the question of if there should be an > \asciicirc (or something) entity for ^ also). I think they are all useful. Though, asciicirc already exists as circ. Could you modify slightly your changelogs before I apply the patches? Thank you. Regards, --=20 Nicolas Goaziou