emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Samuel Wales <samologist@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: bugs in commenting and filling
Date: Fri, 31 Aug 2012 08:10:34 +0200	[thread overview]
Message-ID: <87harjiobp.fsf@gmail.com> (raw)
In-Reply-To: <CAJcAo8vwsaWUSi31DcV-11iNHr=vHYaeNSaE0W2j_Bagw8W+wA@mail.gmail.com> (Samuel Wales's message of "Thu, 30 Aug 2012 19:01:34 -0700")


Samuel Wales <samologist@gmail.com> writes:

> On 8/28/12, Nicolas Goaziou <n.goaziou@gmail.com> wrote:
>>> #bug 4: this paragraph now gets exported in HTML subtree
>>> #export, which will likely surprise many people who formerly
>>> #used "#" comments instead of "# " comments and don't
>>> #carefully check all output.  they might
>>> #even publish private information automatically without
>>> #realizing it using old files that they forgot or did not
>>> #know to convert.
>> This has been announced in 7.9 changes.
> As a user, what is the best way in both the old and new exporters to
> remove #[^+] lines on export?  Flush lines in one of the hooks?  Or is
> there a setting?

You can flush such lines in a hook:

#+begin_src emacs-lisp
(defun my-flush-old-comment-syntax (backend)
  (while (re-search-forward "^#[^ \t+]" nil t)
    (when (memq (org-element-type (org-element-at-point))
                '(paragraph verse-block))
      (delete-region (line-beginning-position)
                     (progn (forward-line) (point))))))

(add-hook 'org-export-before-parsing-hook 'my-flush-old-comment-syntax)

> Or error if there are any such lines in the exported subtree.  (I
> always export subtrees.)  Is this possible?

For a warning, you may want to have something like:

#+begin_src emacs-lisp
(defun my-old-comment-syntax-warning (backend)
  (when (re-search-forward "^#[^ \t+]" nil t)
    (or (yes-or-no-p "Document may contain old-style comment syntax.  Still proceed? ")
        (error "Export aborted"))))

(add-hook 'org-export-before-parsing-hook 'my-old-comment-syntax-warning)

>>> #bug 5: filling this paragraph with "===" on the following
>>> #line will fill the ===, unlike the rest of emacs with
>>> #filladapt turned ON.  we are supposed to not use filladapt
>>> #with org.  therefore, how do you emulate the filladapt
>>> #behavior so that there is consistency between emacs and
>>> #org?
>> I don't know filladapt.el. I've done my homework, though, and looked at
>> the file.
>> If you want to use filladapt.el, you'll have to tweak
>> `filladapt-token-*' variables. If you come up with a working setup,
>> please put it on org-hacks.org as some users may appreciate it.
>> For example, `cc-mode' does it in `c-setup-filladapt' function.
> filladapt worked as it does in the rest of Emacs until pretty
> recently, but it stopped working (error) when Org changed filling.

If the error, which you haven't reported yet, happens when using
filladapt, then filladapt has to be tweaked.

> This bug refers to how Org without filladapt works.
> Are you suggesting getting it to work again, then fixing this bug?  My
> concern is that further changes in Org might make it not work again.
> The alternative is to make the Org behavior work as it used to with
> filladapt.

I am probably misunderstanding "bug 5". May you describe it again along
with both the expected and actual behaviour in the situation?


Nicolas Goaziou

  reply	other threads:[~2012-08-31  6:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-27 16:44 bugs in commenting and filling Samuel Wales
2012-08-28 11:44 ` Nicolas Goaziou
2012-08-31  2:01   ` Samuel Wales
2012-08-31  6:10     ` Nicolas Goaziou [this message]
2012-08-31  7:20       ` Samuel Wales
2012-08-31  7:32       ` Samuel Wales
2012-08-31  7:34         ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87harjiobp.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=samologist@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).