emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Yann Hodique <yann.hodique@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix inconsistency in drawer handling
Date: Wed, 19 Sep 2012 16:02:31 +0200	[thread overview]
Message-ID: <87haqudsaw.fsf@gmail.com> (raw)
In-Reply-To: <m2txuxnbm0.fsf@jarvis.hodique.info> (Yann Hodique's message of "Sun, 16 Sep 2012 19:03:51 +0200")

Hello,

Yann Hodique <yann.hodique@gmail.com> writes:

> thanks for the quick review. Of course I don't mind, but I'm just
> curious to understand the purpose, as duplicating constants seems to
> make room for future mistakes (even though in this case I guess we're
> stuck with that regexp forever :)).

As far as Org Element goes, there's no duplication as each regexp would
be used but once.

My point is that such constants do not make much sense. You are not
guaranteed to find a real drawer when you use

  (re-search-forward org-drawer-regexp)

even if the regexp matches: you also need to make sure that

  (eq (org-element-type (org-element-at-point)) 'drawer)

is non-nil. Worse, I think that these constants are misleading as they
sound self-sufficient. Therefore, I'd rather not support them in
Elements. But I may be too cautious on this. What do you think?

In the long run, I think that, structure-wise, org.el should handle any
action directly related to headlines, but org-element.el should be the
core library for everything else.


Regards,

-- 
Nicolas Goaziou

      reply	other threads:[~2012-09-19 14:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-15 12:00 [PATCH] Fix inconsistency in drawer handling Yann Hodique
2012-09-15 12:00 ` Yann Hodique
2012-09-15 12:36 ` Nicolas Goaziou
2012-09-16 17:03   ` Yann Hodique
2012-09-19 14:02     ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87haqudsaw.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=yann.hodique@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).