emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Agenda priority setting bad feature
@ 2012-09-27 13:32 Robert Horn
  2012-09-27 22:32 ` Bastien
  0 siblings, 1 reply; 7+ messages in thread
From: Robert Horn @ 2012-09-27 13:32 UTC (permalink / raw)
  To: Org-mode

I think that the key mapping for "," and "C-c," in agenda is a mistake
and should be swapped.  In the normal org-mode, "C-c ," is mapped to
org-priority.  In agenda mode this gets changed to
org-agenda-show-priority. In agenda mode "," is mapped to
org-agenda-priority, which behaves like org-priority.
This is very confusing.

We should swap the mapping or find some other mapping for
org-agenda-show-priority. That doesn't confuse the keystroke memory of
users or introduce an inconsistency between modes.  If agenda mode was
all that we had to deal with, this would not be an issue.  But it's more
important to keep things consistent within org-mode.  

Sorry for missing any earlier discussion of this.  I didn't notice a
proposal to introduce keystroke meaning inconsistency within org-mode.

This change appeared between 7.8.11 and 7.9.

R Horn

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Agenda priority setting bad feature
  2012-09-27 13:32 Agenda priority setting bad feature Robert Horn
@ 2012-09-27 22:32 ` Bastien
  2012-09-28  1:06   ` Robert Horn
  0 siblings, 1 reply; 7+ messages in thread
From: Bastien @ 2012-09-27 22:32 UTC (permalink / raw)
  To: Robert Horn; +Cc: Org-mode

Robert Horn <rjhorn@alum.mit.edu> writes:

> I think that the key mapping for "," and "C-c," in agenda is a mistake
> and should be swapped.  

The agenda is read-only, so short keystrokes are often preferred 
over long one.  "," being short for "C-c ," looks natural and intuitive,
so I don't think the change is necessary.

But, I'm open to other advice.

-- 
 Bastien

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Agenda priority setting bad feature
  2012-09-27 22:32 ` Bastien
@ 2012-09-28  1:06   ` Robert Horn
  2012-09-28  6:32     ` Bastien
  0 siblings, 1 reply; 7+ messages in thread
From: Robert Horn @ 2012-09-28  1:06 UTC (permalink / raw)
  To: Bastien; +Cc: Org-mode

FBastien <bzg@altern.org> writes:

> Robert Horn <rjhorn@alum.mit.edu> writes:
>
>> I think that the key mapping for "," and "C-c," in agenda is a mistake
>> and should be swapped.  
>
> The agenda is read-only, so short keystrokes are often preferred 
> over long one.  "," being short for "C-c ," looks natural and intuitive,
> so I don't think the change is necessary.
>

The agenda is not read-only for this command.  The current "," modifies
both the agenda and the source org file to change the priority.  In
org-mode, this modification is made by "C-c ,".  If agenda were
read-only I wouldn't have made the suggestion.  What tripped me up is
that the key combination that I use to change priority in org-mode
didn't work in agenda-mode.  In earlier versions of org mode, up to
7.8.11 the "C-c ," did change the priority in agenda mode.

Since the priority is already displayed as part of the line in the
agenda, I don't see the priority of having another command that 
displays it in the minibuffer.

An equally good fix is to have both "," and "C-c ," make the priority
modifcation.  (Basically change the key-map so that both "," and "C-c ,"
map to org-agenda-priority.)

R Horn

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Agenda priority setting bad feature
  2012-09-28  1:06   ` Robert Horn
@ 2012-09-28  6:32     ` Bastien
  2012-10-08 20:11       ` Michael Brand
  0 siblings, 1 reply; 7+ messages in thread
From: Bastien @ 2012-09-28  6:32 UTC (permalink / raw)
  To: Robert Horn; +Cc: Org-mode

You can now use both `,' and `C-c ,' in agenda to set the priority.

You can also use `C-u ,' and `C-u C-c ,' to see the see the priority.
Note that the priority displayed is a number, not the priority cookie.
Also this number for the same headline will differ in agendas and in
Org buffers, as the priority is dynamically computed in agenda.

There is also a new speedy command "," to set the priority when point
is at the beginning of a headline.

Thanks,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Agenda priority setting bad feature
  2012-09-28  6:32     ` Bastien
@ 2012-10-08 20:11       ` Michael Brand
  2012-12-30 10:35         ` Bastien
  0 siblings, 1 reply; 7+ messages in thread
From: Michael Brand @ 2012-10-08 20:11 UTC (permalink / raw)
  To: Bastien; +Cc: Org-mode

Hi Bastien

On Fri, Sep 28, 2012 at 8:32 AM, Bastien <bzg@altern.org> wrote:
> You can now use both `,' and `C-c ,' in agenda to set the priority.
>
> You can also use `C-u ,' and `C-u C-c ,' to see the see the priority.
> Note that the priority displayed is a number, not the priority cookie.
> Also this number for the same headline will differ in agendas and in
> Org buffers, as the priority is dynamically computed in agenda.
>
> There is also a new speedy command "," to set the priority when point
> is at the beginning of a headline.

With the related commit release_7.9.1-93-ge8b45bb the agenda view
priority of all entries in the agenda view becomes -1000. Before, most
of all the scheduled and deadline were different for different target
dates.

Only as an idea for an improvement at the same time: Instead of, or
additional to showing the agenda view priority of just the current
entry in the minibuffer it could be helpful to toggle preceding each
agenda view line with the agenda view priority for understanding
purposes. Similar to C-c } (org-table-toggle-coordinate-overlays) on a
table.

Michael

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Agenda priority setting bad feature
  2012-10-08 20:11       ` Michael Brand
@ 2012-12-30 10:35         ` Bastien
  2012-12-30 13:17           ` Michael Brand
  0 siblings, 1 reply; 7+ messages in thread
From: Bastien @ 2012-12-30 10:35 UTC (permalink / raw)
  To: Michael Brand; +Cc: Org-mode

Hi Michael,

Michael Brand <michael.ch.brand@gmail.com> writes:

> With the related commit release_7.9.1-93-ge8b45bb the agenda view
> priority of all entries in the agenda view becomes -1000. Before, most
> of all the scheduled and deadline were different for different target
> dates.

This is now fixed in maint.

> Only as an idea for an improvement at the same time: Instead of, or
> additional to showing the agenda view priority of just the current
> entry in the minibuffer it could be helpful to toggle preceding each
> agenda view line with the agenda view priority for understanding
> purposes. Similar to C-c } (org-table-toggle-coordinate-overlays) on a
> table.

I see, yes.  Or support priority numbers in `org-agenda-prefix-format'
and `org-agenda-fontify-priorities'... not on top on my TODO list I'd
say :)

-- 
 Bastien

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Agenda priority setting bad feature
  2012-12-30 10:35         ` Bastien
@ 2012-12-30 13:17           ` Michael Brand
  0 siblings, 0 replies; 7+ messages in thread
From: Michael Brand @ 2012-12-30 13:17 UTC (permalink / raw)
  To: Bastien; +Cc: Org-mode

Hi Bastien

On Sun, Dec 30, 2012 at 11:35 AM, Bastien <bzg@altern.org> wrote:
> Michael Brand <michael.ch.brand@gmail.com> writes:
>> With the related commit release_7.9.1-93-ge8b45bb the agenda view
>> priority of all entries in the agenda view becomes -1000. Before, most
>> of all the scheduled and deadline were different for different target
>> dates.
>
> This is now fixed in maint.

Thank you.

Michael

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2012-12-30 13:18 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-27 13:32 Agenda priority setting bad feature Robert Horn
2012-09-27 22:32 ` Bastien
2012-09-28  1:06   ` Robert Horn
2012-09-28  6:32     ` Bastien
2012-10-08 20:11       ` Michael Brand
2012-12-30 10:35         ` Bastien
2012-12-30 13:17           ` Michael Brand

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).