emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Christopher Schmidt <christopher@ch.ristopher.com>
To: emacs-orgmode@gnu.org
Subject: Re: TeX-master: TeX-master is let-bound
Date: Thu, 24 Jan 2013 19:25:31 +0000 (GMT)	[thread overview]
Message-ID: <87ham6s7rf@ch.ristopher.com> (raw)
In-Reply-To: <87mwz98vz4@ch.ristopher.com> (Christopher Schmidt's message of "Fri, 26 Oct 2012 09:43:12 +0100 (BST)")

[-- Attachment #1: Type: text/plain, Size: 818 bytes --]

Christopher Schmidt <christopher@ch.ristopher.com> writes:
> The default value it t anyway.  The docstring suggests that this
> variable should be set via file variables.  I do not think org-mode
> should worry about AUCTeX.

Ping?

The default value of TeX-master is t.  Binding a symbol which might be
defvar'ed within the let-body does not work.  In fact, this might break
the Emacs instance, rendering any latex-mode buffer unusable.

To make a long story short, there is no excuse for the form in question.
Please remove it.  Everyone who messes with TeX-master should use
org-export-latex-final-hook to set TeX-master and/or add a local
variables list to the buffer.

    2013-01-24  Christopher Schmidt  <christopher@ch.ristopher.com>

            * org-latex.el (org-export-as-latex): Do not bind TeX-master.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-diff, Size: 949 bytes --]

--- a/lisp/org-latex.el
+++ b/lisp/org-latex.el
@@ -964,7 +964,6 @@ When PUB-DIR is set, use this as the publishing directory."
                   (concat filename ".tex")
                 filename)))
         (auto-insert nil); Avoid any auto-insert stuff for the new file
-        (TeX-master (boundp 'TeX-master))
         (buffer (if to-buffer
                     (if (eq to-buffer 'string)
                         (get-buffer-create "*Org LaTeX Export*")
@@ -1105,9 +1104,11 @@ When PUB-DIR is set, use this as the publishing directory."
     (or (eq (char-before) ?\n)
        (insert ?\n))

+    (when (and to-buffer
+               (not (derived-mode-p 'latex-mode)))
+      (latex-mode))
     (run-hooks 'org-export-latex-final-hook)
-    (if to-buffer
-	(unless (eq major-mode 'latex-mode) (latex-mode))
+    (unless to-buffer
       (save-buffer))
     (org-export-latex-fix-inputenc)
     (run-hooks 'org-export-latex-after-save-hook)

[-- Attachment #3: Type: text/plain, Size: 33 bytes --]


Thank you,

        Christopher

  parent reply	other threads:[~2013-01-24 19:25 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-25 16:48 Christopher Schmidt
2012-10-25 21:45 ` Suvayu Ali
2012-10-25 22:19   ` Christopher Schmidt
2012-10-26  6:51     ` Suvayu Ali
2012-10-26  8:43       ` Christopher Schmidt
2012-10-26  9:30         ` Christopher Witte
2012-10-26 11:41           ` Suvayu Ali
2012-10-26 15:34           ` Christopher Schmidt
     [not found]             ` <christopher@ch.ristopher.com>
2012-10-26 16:31               ` Nick Dokos
2012-10-29 21:18                 ` Christopher Schmidt
2012-10-29 22:25               ` Nick Dokos
2012-10-29 22:57                 ` Christopher Schmidt
2013-02-23  9:16                   ` Bastien
2013-02-23 14:32                     ` Christopher Schmidt
2013-03-02 15:11                       ` Bastien
2012-11-01 14:50                 ` Christopher Schmidt
2012-10-29 23:25               ` Nick Dokos
2012-10-30  7:52                 ` Christopher Schmidt
2012-10-30 17:45               ` Nick Dokos
2012-10-30 19:01                 ` Christopher Schmidt
2012-10-30 20:32                 ` Sebastien Vauban
2012-10-30 20:54                   ` Nick Dokos
2012-11-01 15:22               ` Nick Dokos
2013-01-24 19:25         ` Christopher Schmidt [this message]
2013-01-25 10:42           ` Bastien
2013-01-25 11:36             ` Christopher Schmidt
2013-01-26 13:54               ` Christopher Schmidt
2013-01-26 14:20                 ` Bastien
2013-01-26 14:28                   ` Christopher Schmidt
2013-01-26 15:35                     ` Bastien
2013-01-26 16:23                       ` Christopher Schmidt
2013-02-19 10:38           ` Christopher Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ham6s7rf@ch.ristopher.com \
    --to=christopher@ch.ristopher.com \
    --cc=emacs-orgmode@gnu.org \
    --subject='Re: TeX-master: TeX-master is let-bound' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).