From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dokos Subject: Re: [BUG] Infinite loop in org-agenda-show-new-time Date: Fri, 23 Aug 2013 08:07:58 -0400 Message-ID: <87haegy5i9.fsf@gmail.com> References: <87zjswb0vq.fsf@fastmail.fm> <87siyojc2c.fsf@gmail.com> <87fvun6gku.fsf@fastmail.fm> <87ob9bkd4c.fsf@gmail.com> <87txj2lo0j.fsf@fastmail.fm> <87mwopinzv.fsf@gmail.com> <87fvucuwva.fsf@fastmail.fm> <87vc38ff84.fsf@gmail.com> <3E07FCDB-2619-4BFE-BC68-C5181717152B@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCqA5-0007Ox-Fg for emacs-orgmode@gnu.org; Fri, 23 Aug 2013 08:08:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCq9z-000069-9d for emacs-orgmode@gnu.org; Fri, 23 Aug 2013 08:08:17 -0400 Received: from plane.gmane.org ([80.91.229.3]:53052) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCq9z-00005c-2I for emacs-orgmode@gnu.org; Fri, 23 Aug 2013 08:08:11 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1VCq9x-0000Ql-Lj for emacs-orgmode@gnu.org; Fri, 23 Aug 2013 14:08:09 +0200 Received: from pool-108-7-96-134.bstnma.fios.verizon.net ([108.7.96.134]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 23 Aug 2013 14:08:09 +0200 Received: from ndokos by pool-108-7-96-134.bstnma.fios.verizon.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 23 Aug 2013 14:08:09 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Carsten Dominik writes: > I also do not expect negative consequences. Please apply the patch, will you? > OK - patch attached. NB: there is at least one place where the "wrap the call to org-move-to-column" has been applied, in org.el:`org-comment-or-uncomment-region', presumably for exactly this reason. If this patch does not cause unexpected problem, then the wrapped setting above can be cleaned up. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-infinite-loop-in-org-agenda-show-new-time.patch Content-Description: Patch for Matt Lundin's infloop >From b0aebe182a72df8e7d5428a02e0eca7a6922fefe Mon Sep 17 00:00:00 2001 From: Nick Dokos Date: Fri, 23 Aug 2013 07:42:44 -0400 Subject: [PATCH] Fix infinite loop in org-agenda-show-new-time * lisp/org-agenda.el (org-move-to-column): Make sure that `buffer-invisibility-spec' is nil when calling move-to-column. This was caused by a previous commit (fafb5f34) which eliminated the setting of `buffer-invisibility-spec' in `org-agenda-show-new-time'. Matt Lundin ran into this and there is a discussion on the ML: http://thread.gmane.org/gmane.emacs.orgmode/75288 --- lisp/org-compat.el | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lisp/org-compat.el b/lisp/org-compat.el index d10aeea..c4d15d8 100644 --- a/lisp/org-compat.el +++ b/lisp/org-compat.el @@ -336,9 +336,12 @@ Works on both Emacs and XEmacs." (indent-line-to column))) (defun org-move-to-column (column &optional force buffer) - (if (featurep 'xemacs) - (org-xemacs-without-invisibility (move-to-column column force buffer)) - (move-to-column column force))) + ;; set buffer-invisibility-spec to nil so that move-to-column + ;; does the right thing despite the presence of invisible text. + (let ((buffer-invisibility-spec nil)) + (if (featurep 'xemacs) + (org-xemacs-without-invisibility (move-to-column column force buffer)) + (move-to-column column force)))) (defun org-get-x-clipboard-compat (value) "Get the clipboard value on XEmacs or Emacs 21." -- 1.8.3.101.g727a46b --=-=-= Content-Type: text/plain I hope it conforms to conventions but let me know of any problems. -- Nick --=-=-=--