emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Sylvain Chouleur <sylvain.chouleur@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix org-outline-overlay-data marker insertion-type
Date: Sat, 18 Jan 2014 18:43:54 +0100	[thread overview]
Message-ID: <87ha91uqw5.fsf@gmail.com> (raw)
In-Reply-To: <CAD_mUW2h1mUu7R9cp_JHO+ytmYEu9hbfFgqfc_6fm2J6xzoWkQ@mail.gmail.com> (Sylvain Chouleur's message of "Sat, 18 Jan 2014 18:27:55 +0100")

Hello,

Sylvain Chouleur <sylvain.chouleur@gmail.com> writes:

> A little fix on my last patch:

Thanks for your patch. A small style comment.

> +				   (let ((bound
> +					  (cons (move-marker (make-marker) beg)
> +						(move-marker (make-marker) end))))
> +				     (set-marker-insertion-type (car bound) t)
> +				     (set-marker-insertion-type (cdr bound) t)
> +				     bound)

All of this is really a one-liner:

  (cons (copy-marker beg t) (copy-marker end t))


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2014-01-18 17:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-15  0:19 [PATCH] Fix org-outline-overlay-data marker insertion-type Sylvain Chouleur
2014-01-18 17:27 ` Sylvain Chouleur
2014-01-18 17:43   ` Nicolas Goaziou [this message]
2014-01-18 18:35     ` Sylvain Chouleur
2014-01-18 19:57       ` Nicolas Goaziou
2014-01-19 13:20         ` Sylvain Chouleur
2014-01-19 19:38           ` Nicolas Goaziou
2014-01-19 19:46             ` Sylvain Chouleur
2014-01-19 21:06               ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ha91uqw5.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=sylvain.chouleur@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).