From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: [PATCH] Noweb expansion doesn't duplicate prefix across lines Date: Wed, 02 Apr 2014 17:07:07 -0600 Message-ID: <87ha6ao5xj.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WViQa-0004pI-Ba for emacs-orgmode@gnu.org; Thu, 03 Apr 2014 10:15:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WViQU-0005um-9X for emacs-orgmode@gnu.org; Thu, 03 Apr 2014 10:15:36 -0400 Received: from mail-pa0-x230.google.com ([2607:f8b0:400e:c03::230]:60616) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WViQT-0005uf-VZ for emacs-orgmode@gnu.org; Thu, 03 Apr 2014 10:15:30 -0400 Received: by mail-pa0-f48.google.com with SMTP id hz1so1914274pad.7 for ; Thu, 03 Apr 2014 07:15:29 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Pontus Michael Cc: emacs-orgmode@gnu.org This simply seems to trade one use case (noweb expansion behind a prefix), with another (multiple noweb expansions on the same line). Is there a way to support both use cases? Pontus Michael writes: > * lisp/ob-core.el (org-babel-expand-noweb-references): Change the the > behavior of noweb expansion by replacing the prefix duplication with > whitespace. Fix handling of multiple noweb references on the same > line by using temporary buffer to replace noweb references in place > instead of collecting the intervals between references and their > expansion text into a variable. > > * doc/org.texi: Reflect the change by removing the section under > subheading "Noweb prefix lines". > > Tests pass and don't require actualization. > --- > doc/org.texi | 24 ------------------------ > lisp/ob-core.el | 26 +++++++------------------- > 2 files changed, 7 insertions(+), 43 deletions(-) > -- Eric Schulte https://cs.unm.edu/~eschulte PGP: 0x614CA05D