From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: org-bbdb link completion fix Date: Mon, 28 Apr 2014 16:55:05 +0200 Message-ID: <87ha5dpkqe.fsf@gmail.com> References: <87a9b5ssux.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wemx9-0003rt-UC for emacs-orgmode@gnu.org; Mon, 28 Apr 2014 10:54:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wemx3-0004EN-OM for emacs-orgmode@gnu.org; Mon, 28 Apr 2014 10:54:43 -0400 Received: from mail-we0-x22e.google.com ([2a00:1450:400c:c03::22e]:38839) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wemx3-0004EC-Hs for emacs-orgmode@gnu.org; Mon, 28 Apr 2014 10:54:37 -0400 Received: by mail-we0-f174.google.com with SMTP id w62so5289260wes.33 for ; Mon, 28 Apr 2014 07:54:36 -0700 (PDT) In-Reply-To: <87a9b5ssux.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 28 Apr 2014 17:31:18 +0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Eric Abrahamsen Cc: emacs-orgmode@gnu.org Hello, Eric Abrahamsen writes: > The most recent versions of BBDB return single records from > `bbdb-completing-read-record'. That currently breaks completion on bbdb: > links -- possibly earlier versions of BBDB always returned list values. > > We should probably check for this in `org-bbdb-complete-link', I propose > the attached patch. Thank you for the patch. Would you mind providing a proper commit message and send it again? Regards, -- Nicolas Goaziou