From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH} Re: Bug: problem when exporting a org-mode file with a lots of code blocks Date: Wed, 11 Mar 2015 08:40:28 +0100 Message-ID: <87h9tsyob7.fsf@nicolasgoaziou.fr> References: <87d24hs3pa.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVbEd-0003eM-Mi for emacs-orgmode@gnu.org; Wed, 11 Mar 2015 03:39:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVbEb-0002Je-24 for emacs-orgmode@gnu.org; Wed, 11 Mar 2015 03:39:19 -0400 Received: from relay6-d.mail.gandi.net ([2001:4b98:c:538::198]:43104) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVbEa-0002JS-SM for emacs-orgmode@gnu.org; Wed, 11 Mar 2015 03:39:16 -0400 In-Reply-To: (Charles C. Berry's message of "Tue, 10 Mar 2015 14:22:51 -0700") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "Charles C. Berry" Cc: emacs-orgmode@gnu.org Hello, "Charles C. Berry" writes: > The patch causes an informative error message to be reported for src > blocks like this (no language): > > #+begin_src > (+ 1 2) > #_end_src Thanks. However could you move the check for language earlier (i.e., right after "(src-block ...)")? > Arguably, it would be better to skip the malformed src block as > `org-babel-map-src-blocks' does or (as per John's message) > org-babel-tangle does. The current trend is to throw an error when something is missing during export (e.g., a footnote definition, a macro template). So it's fine. Regards, -- Nicolas Goaziou