From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kyle Meyer <kyle@kyleam.com>
Subject: Re: [PATCH] make org-clock-time% respect org-effort-durations and
 related
Date: Sun, 25 Oct 2015 13:23:19 -0400
Message-ID: <87h9le981k.fsf@kyleam.com>
References: <1445777293-13909-1-git-send-email-oxij@oxij.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53299)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1ZqP0u-0003la-Fp
	for emacs-orgmode@gnu.org; Sun, 25 Oct 2015 13:23:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1ZqP0r-0001Eq-C9
	for emacs-orgmode@gnu.org; Sun, 25 Oct 2015 13:23:24 -0400
Received: from mail-qg0-x22e.google.com ([2607:f8b0:400d:c04::22e]:36758)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1ZqP0r-0001ES-6l
	for emacs-orgmode@gnu.org; Sun, 25 Oct 2015 13:23:21 -0400
Received: by qgad10 with SMTP id d10so103304176qga.3
	for <emacs-orgmode@gnu.org>; Sun, 25 Oct 2015 10:23:20 -0700 (PDT)
In-Reply-To: <1445777293-13909-1-git-send-email-oxij@oxij.org> (Jan
	Malakhovski's message of "Sun, 25 Oct 2015 12:48:09 +0000")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Jan Malakhovski <oxij@oxij.org>
Cc: emacs-orgmode@gnu.org

Hello,

Jan Malakhovski <oxij@oxij.org> writes:

> Hi.
>
> The first patch here is a must, because it fixes a bug I stumble upoon
> daily. Middle two are just to make the names consistent. While doing
> all those changes I read quite a lot of code and the last patch adds a
> FIXME for a particularly ugly place I'm not sure how to fix (I think
> don't ever consciously use that code path and I'm not sure what it
> supposed to do).

Thanks for these patches, as well as the other series you sent [1].  I
haven't looked at the content in detail, but based on the diffstats,
these changes are touching enough lines to require copyright assignment
[2].  Also, please include a ChangeLog entry in the commit message [3].

Thanks again.

[1] http://thread.gmane.org/gmane.emacs.orgmode/102168
[2] http://orgmode.org/worg/org-contribute.html#orgheadline2
[3] http://orgmode.org/worg/org-contribute.html#orgheadline6

--
Kyle