From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Abrahamsen <eric@ericabrahamsen.net>
Subject: Re: Agenda filter by any tag seems to be broken
Date: Thu, 19 May 2016 21:46:04 +0800
Message-ID: <87h9du6u03.fsf@ericabrahamsen.net>
References: <87oa8a7hxp.fsf@ericabrahamsen.net>
	<CAFyQvY1ke7GhV4QLt-AvW53LnSji44+F-iQ+NvYWH8iTxcn6YQ@mail.gmail.com>
	<8760udh644.fsf@ericabrahamsen.net>
	<CAFyQvY2N3nVk6Ab=mgJ9R=Ttdy2iM3osgHznL3nRkg17Qf0b6w@mail.gmail.com>
	<87wpms3uu2.fsf@ericabrahamsen.net> <87eg8ywigz.fsf@saiph.selenimh>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44254)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1b3OHQ-0006aT-VC
	for emacs-orgmode@gnu.org; Thu, 19 May 2016 09:46:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1b3OHM-0000W7-0K
	for emacs-orgmode@gnu.org; Thu, 19 May 2016 09:46:23 -0400
Received: from plane.gmane.org ([80.91.229.3]:43033)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1b3OHL-0000W1-PJ
	for emacs-orgmode@gnu.org; Thu, 19 May 2016 09:46:19 -0400
Received: from list by plane.gmane.org with local (Exim 4.69)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1b3OHK-0006GO-B3
	for emacs-orgmode@gnu.org; Thu, 19 May 2016 15:46:18 +0200
Received: from 111.197.153.131 ([111.197.153.131])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Thu, 19 May 2016 15:46:18 +0200
Received: from eric by 111.197.153.131 with local (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Thu, 19 May 2016 15:46:18 +0200
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: emacs-orgmode@gnu.org

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Okay, there's the problem. In the org git repo, the code above has been
>> that way since it was added in 2015. In the package-manager version,
>> however, it now looks like this:
>>
>>       (let* ((tag (substring x 1))
>> 	     (isregexp (and (equal "{" (substring tag 0 1))
>> 			    (equal "}" (substring tag -1))))
>> 	     regexp)
>>
>> And the `substring' calls raise the error. The code is the same in the
>> "org" and "org-plus-contrib" packages.
>>
>> I don't know where the different code comes from, or who maintains it,
>> or why it's different from the org git repo, but it would be nice if
>> someone could look into fixing that!
>
> Fixed. Thank you for the detailed report.

Great, thanks a lot!