emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Nicolas Dudebout <nicolas.dudebout@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-agenda: make log and clockreport modes local
Date: Thu, 22 Feb 2018 14:39:36 +0100	[thread overview]
Message-ID: <87h8q9i1nr.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CA+TMmKm=s1Wei=QE4gLZOQPqAVsvd1kwGgaqBWarcqV1RGvTUw@mail.gmail.com> (Nicolas Dudebout's message of "Wed, 21 Feb 2018 21:42:19 -0500")

Hello,

Nicolas Dudebout <nicolas.dudebout@gmail.com> writes:

> `org-agenda-show-log' indicates if the the current agenda buffer has
> log-mode enabled.  When building a new agenda buffer, it gets its
> value from `org-agenda-start-with-log-mode'.  It is is semantically a
> buffer local variable: when creating a new agenda buffer you expect it
> to be set to the value in `org-agenda-start-with-log-mode'.  However,
> 2e9c2d71 while fixing an issue with sticky agendas rendered the
> variable `org-agenda-log-mode' effectively global: toggling log mode
> in a given agenda buffer modifies the global default for all agenda
> buffers.  The same reasoning holds for clockreport mode.
>
> This change ensures that a log or clockreport mode change made in one
> agenda buffer does not propagate to other agenda buffers, existing or
> new.  The change is however preserved on org-agenda-redo in the
> initial agenda buffer, whether using sticky agendas or not.

Applied. Thank you.

I don't know if you signed FSF papers already. Therefore, I added
TINYCHANGE at the end of the commit message.

Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2018-02-22 13:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22  2:42 [PATCH] org-agenda: make log and clockreport modes local Nicolas Dudebout
2018-02-22 13:39 ` Nicolas Goaziou [this message]
2018-02-22 14:20   ` Nicolas Dudebout
2018-02-22 20:41     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8q9i1nr.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=nicolas.dudebout@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).