From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [patch] fix error when using org-notify with no agenda files Date: Tue, 10 Apr 2018 20:11:33 +0200 Message-ID: <87h8ojrkx6.fsf@nicolasgoaziou.fr> References: <87muyb2577.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f5xk6-0007G9-Np for emacs-orgmode@gnu.org; Tue, 10 Apr 2018 14:11:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f5xk3-0000Hw-Je for emacs-orgmode@gnu.org; Tue, 10 Apr 2018 14:11:42 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:48763) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f5xk3-0000C4-CR for emacs-orgmode@gnu.org; Tue, 10 Apr 2018 14:11:39 -0400 In-Reply-To: <87muyb2577.fsf@gmail.com> (Jay Kamat's message of "Mon, 09 Apr 2018 22:02:47 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Jay Kamat Cc: Org Mode Hello, Jay Kamat writes: > Hi, > > Previously, when `org-agenda-files' was nil, and `org-notify-start' had > been called (org-notify running), I got the following error every time > `org-notify-process' would run. > > Wrong type argument: stringp, nil > > This patch fixes this so `org-notify' won't throw errors if no agenda > files are present. Applied. Thank you. > > Please let me know if you spot any issues. I thought about adding a > one-time message warning the user, would this be a good idea (or should > we just stay out of their way)? I would be happy to implement it if that > would be preferable. I think the current state is good enough. Regards, -- Nicolas Goaziou