From: Aaron Ecay <aaronecay@gmail.com>
To: "Göktuğ Kayaalp" <self@gkayaalp.com>, emacs-orgmode@gnu.org
Subject: Re: Inheriting some local variables from source code block editing buffers
Date: Mon, 14 May 2018 14:33:09 +0100 [thread overview]
Message-ID: <87h8najrai.fsf@gmail.com> (raw)
In-Reply-To: <ygmefie3i6o.fsf@gkayaalp.com>
Hi Göktuğ,
This patch looks good, thanks. Of course, for merging to org core it
will need to be an actual patch and not advice. There is also copyright
assignment to think of. Do you already have a FSF copyright assignment
on file?
2018ko maiatzak 14an, Göktuğ Kayaalp-ek idatzi zuen:
[...]
> One ‘gotcha’ is that :edit-bindings requires a quoted list whereas the
> explicit quote is not necessary with ATTR_EDIT:
>
> #+BEGIN_SRC elisp :edit-bindings '((lexical-binding t))
> #+ATTR_EDIT: ((lexical-binding t))
That quote is required for the src block version is inherent in the
design of babel. For consistency, you could require (or at least permit
without requiring) a quote in the other case as well.
>
> Another problem is that I was not able to define a new element property
> named EDIT_BINDINGS, and had to take the shortcut with naming it as an
> ATTR_* variable. Preferably, it'd be EDIT_BINDINGS instead:
>
> #+BEGIN_SRC elisp :edit-bindings '((lexical-binding t))
> #+EDIT_BINDINGS: ((lexical-binding t))
>
> But personally I don't think it's that big of a problem.
>
>
> The advice:
>
> (define-advice org-src--edit-element
> (:around
> (fn datum &rest args)
> attr-edit&edit-bindings)
> "Apply edit-special bindings."
> (let ((attr-edit (org-element-property :attr_edit datum))
> (edit-bindings
> (assoc :edit-bindings (caddr (org-babel-get-src-block-info nil datum))))
> (source-buffer (current-buffer))
> (sub (lambda (varlist source-buffer)
> (let (var val)
> (dolist (form varlist)
> ;; If it's a symbol, inherit from the Org mode buffer.
> (if (symbolp form)
> (setq var form
> val (with-current-buffer source-buffer (eval var)))
> ;; Else, apply the specified value.
> (setq var (car form) val (cadr form)))
> (unless (symbolp var)
> ;; XXX: maybe tell where it is?
> (user-error "Bad varlist at ATTR_EDIT"))
> (set (make-local-variable var) val))))))
I think you could replace the (let (var val)...) form with:
#+begin_src emacs-lisp
(pcase-dolist ((or (and (pred symbolp) var
(let val (buffer-local-value var source-buffer)))
`(,var ,val))
varlist)
(set (make-local-variable var) val))
#+end_src
This silently skips varlist entries that are of the wrong shape, but it
would be possible to make it raise an error as in your version. I like
the pcase version better because itʼs shorter and has fewer nested
conditionals, but itʼs ultimately a matter of taste.
--
Aaron Ecay
next prev parent reply other threads:[~2018-05-14 13:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-29 17:19 Inheriting some local variables from source code block editing buffers Göktuğ Kayaalp
2018-04-29 22:09 ` Bastien
2018-05-01 3:30 ` Göktuğ Kayaalp
2018-05-01 8:43 ` Nicolas Goaziou
2018-05-01 8:45 ` Nicolas Goaziou
2018-05-01 11:41 ` Göktuğ Kayaalp
2018-05-01 11:55 ` Nicolas Goaziou
[not found] ` <ygmvac7lcl1.fsf@gkayaalp.com>
2018-05-01 14:00 ` Nicolas Goaziou
2018-05-01 16:37 ` Aaron Ecay
[not found] ` <ygmin87kwua.fsf@gkayaalp.com>
2018-05-01 19:35 ` Aaron Ecay
2018-05-01 20:04 ` Göktuğ Kayaalp
2018-05-01 20:53 ` Aaron Ecay
2018-05-01 22:12 ` Göktuğ Kayaalp
2018-05-01 22:19 ` Aaron Ecay
2018-05-01 22:26 ` Göktuğ Kayaalp
2018-05-02 10:16 ` Nicolas Goaziou
2018-05-02 19:52 ` Göktuğ Kayaalp
2018-05-01 11:45 ` Göktuğ Kayaalp
2018-05-14 5:44 ` Göktuğ Kayaalp
2018-05-14 12:13 ` Nicolas Goaziou
2018-05-14 16:34 ` Göktuğ Kayaalp
2018-05-14 16:47 ` Nicolas Goaziou
2018-05-15 18:36 ` Göktuğ Kayaalp
2018-05-18 21:48 ` Göktuğ Kayaalp
2018-05-19 12:26 ` Nicolas Goaziou
2018-05-21 14:20 ` Aaron Ecay
2018-05-14 13:33 ` Aaron Ecay [this message]
2018-05-14 16:46 ` Göktuğ Kayaalp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8najrai.fsf@gmail.com \
--to=aaronecay@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=self@gkayaalp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).