From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: org-open-line inconsistent treatment of marking characters '#' and '*' Date: Sat, 12 Jan 2019 11:42:21 +0100 Message-ID: <87h8eeyx6a.fsf@nicolasgoaziou.fr> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([209.51.188.92]:39165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giGkM-0007x6-Ca for emacs-orgmode@gnu.org; Sat, 12 Jan 2019 05:42:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1giGkJ-0008KW-6d for emacs-orgmode@gnu.org; Sat, 12 Jan 2019 05:42:34 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:42365) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1giGkI-0008I2-0w for emacs-orgmode@gnu.org; Sat, 12 Jan 2019 05:42:30 -0500 In-Reply-To: (Tony E. Bennett's message of "Thu, 10 Jan 2019 11:37:22 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: "Tony E. Bennett" Cc: emacs-orgmode@gnu.org Hello, Tony E. Bennett writes: > org-open-line replicates the table marking character '#' (if present) into > the new table line but does not do the same for '*'. > > Since the semantics of '#' and '*' are so similar I expect them to be > treated identically when opening a new table line. > > Within defun org-table-insert-row, changing this line: > > ;; Fix the first field if necessary > (when (string-match "^[ \t]*| *[#$] *|" line) > > to: > > ;; Fix the first field if necessary > (when (string-match "^[ \t]*| *[#*$] *|" line) > > gives the expected behavior. > > Can this be fixed? OK, I applied the change in maint. However, I tend to think we should not copy any special marker at all, since we don't check if we're in a special column anyway. Regards, -- Nicolas Goaziou