From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] ob-emacs-lisp: Set `lexical-binding' in source editing
 buffers
Date: Tue, 12 Feb 2019 09:41:33 +0100
Message-ID: <87h8d94cw2.fsf@nicolasgoaziou.fr>
References: <CA+ABrMwUK6zx3s4cEEd2bzHFTr==TSMhE6qM4TC2_WevUHh7=A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:42637)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1gtTdc-0007oM-Un
	for emacs-orgmode@gnu.org; Tue, 12 Feb 2019 03:41:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1gtTdb-0005wh-U7
	for emacs-orgmode@gnu.org; Tue, 12 Feb 2019 03:41:56 -0500
Received: from relay3-d.mail.gandi.net ([217.70.183.195]:49981)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1gtTdb-0005g5-HW
	for emacs-orgmode@gnu.org; Tue, 12 Feb 2019 03:41:55 -0500
In-Reply-To: <CA+ABrMwUK6zx3s4cEEd2bzHFTr==TSMhE6qM4TC2_WevUHh7=A@mail.gmail.com>
	(Sebastian Miele's message of "Sun, 10 Feb 2019 13:57:31 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Sebastian Miele <sebastian.miele@gmail.com>
Cc: emacs-orgmode@gnu.org

Hello,

Sebastian Miele <sebastian.miele@gmail.com> writes:

> * lisp/ob-emacs-lisp.el (org-babel-execute:emacs-lisp,
>   org-babel-emacs-lisp-lexical): Factor out the conversion of the
>   :lexical source block argument to a form that is appropriate for
>   `lexical-binding' and the LEXICAL argument to `eval'.
>
> * lisp/ob-emacs-lisp.el (org-babel-edit-prep:emacs-lisp): Set
>   `lexical-binding'.
>
> * lisp/ob-emacs-lisp.el (org-babel-default-header-args:emacs-lisp):
>   Update docstring.

Thank you! Some comments follow.

> -`eval', which see.")
> +`eval', which see. And it is used as the value for
> +`lexical-binding' in buffers created by `org-edit-src-code'.")

You need to add two spaces after full stops.

> +(defun org-babel-emacs-lisp-lexical (lexical)
> +  "Convert :lexical source block argument LEXICAL into the form
> +appropriate for `lexical-binding' and the LEXICAL argument to
> +`eval'."

The first sentence in a docstring needs to fit on a single line.

Could you add a test or two for that feature? Could you also add an
ORG-NEWS entry?

Regards,

-- 
Nicolas Goaziou