emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Pierre Neidhardt <mail@ambrevar.xyz>
To: emacs-orgmode@gnu.org
Subject: org-notmuch: Improved tree support
Date: Tue, 19 Mar 2019 11:07:13 +0100	[thread overview]
Message-ID: <87h8bzb2jy.fsf@bababa.i-did-not-set--mail-host-address--so-tickle-me> (raw)

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

Hi,

1. `org-notmuch-store-link' does not allow to store links to email at
point in tree view.  Easy fix:

--8<---------------cut here---------------start------------->8---
(defun org-notmuch-store-link ()
  "Store a link to a notmuch search or message."
-  (when (eq major-mode 'notmuch-show-mode)
+  (when (or (eq major-mode 'notmuch-show-mode)
+            (eq major-mode 'notmuch-tree-mode))
    (let* ((message-id (notmuch-show-get-message-id t))
--8<---------------cut here---------------end--------------->8---

2. A while back
https://lists.gnu.org/archive/html/emacs-orgmode/2014-07/msg00380.html
was merged.  I think using a defcustom here is not very intuitive for
people who use both the tree view and the thread view.  I would expect
the following:

- Opening a tree link will open the tree view.
- Opening a search link will open the search view.

It's easy to implement:

- Deprecate the former defcustom.
- Copy/paste the org-notmuch-search* code to org-notmuch-tree*.

Thoughts?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

             reply	other threads:[~2019-03-19 10:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-19 10:07 Pierre Neidhardt [this message]
2019-04-03 10:56 ` org-notmuch: Improved tree support Nicolas Goaziou
2019-04-09 17:23   ` Pierre Neidhardt
2019-04-10 13:19     ` Nicolas Goaziou
2019-04-10 13:27       ` Pierre Neidhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8bzb2jy.fsf@bababa.i-did-not-set--mail-host-address--so-tickle-me \
    --to=mail@ambrevar.xyz \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).