From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [PATCH] ob-plantuml: Support for plantuml as well as the current java+jar solution Date: Wed, 12 Feb 2020 18:30:56 +0100 Message-ID: <87h7zvpvan.fsf@gnu.org> References: <874kzeijnz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:43420) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1vr2-0002sr-Pd for emacs-orgmode@gnu.org; Wed, 12 Feb 2020 12:31:17 -0500 In-Reply-To: <874kzeijnz.fsf@gmail.com> (Terje Larsen's message of "Fri, 08 Nov 2019 14:26:08 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Terje Larsen Cc: emacs-orgmode@gnu.org Hi Terje, Terje Larsen writes: > I have been missing this feature for a while and noticed it had already > been requested before (2014), See: > https://lists.gnu.org/archive/html/emacs-orgmode/2016-08/msg00105.html > > With this patch you can switch between using jar or plantuml. The idea > partly stemmed from plantuml-mode and my inability to use the default > implementation. You can see the implementation for plantuml-mode here: > https://github.com/skuro/plantuml-mode/pull/102/files > > My patch is available here: > https://code.orgmode.org/terlar/org-mode/commit/fbe245c0b09513ee5a6d3b189e112708b9d08da0 Thanks for the patch -- I see you're already on the list of committers with TINYCHANGE: https://orgmode.org/worg/org-contribute.html#orgcd077ac Would you like to sign the FSF papers and resubmit your patch on top of current master? https://orgmode.org/request-assign-future.txt Thanks a lot, -- Bastien