From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id Mm66IJoCOV8sNAAA0tVLHw (envelope-from ) for ; Sun, 16 Aug 2020 09:55:38 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6I4mHJoCOV/jFwAAB5/wlQ (envelope-from ) for ; Sun, 16 Aug 2020 09:55:38 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 13EBB940539 for ; Sun, 16 Aug 2020 09:55:38 +0000 (UTC) Received: from localhost ([::1]:44194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k7FO4-0001mg-2P for larch@yhetil.org; Sun, 16 Aug 2020 05:55:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k7FNW-0001mN-U2 for emacs-orgmode@gnu.org; Sun, 16 Aug 2020 05:55:02 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:35175) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k7FNU-0001xw-Q4 for emacs-orgmode@gnu.org; Sun, 16 Aug 2020 05:55:02 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 0B9421BF207; Sun, 16 Aug 2020 09:54:56 +0000 (UTC) From: Nicolas Goaziou To: "numbchild\@gmail.com" Subject: Re: [PATCH] improve ol-man.el with occur searching References: Mail-Followup-To: "numbchild\@gmail.com" , Org-mode Date: Sun, 16 Aug 2020 11:54:56 +0200 In-Reply-To: (numbchild@gmail.com's message of "Fri, 14 Aug 2020 12:41:00 +0800") Message-ID: <87h7t2q5jj.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.201; envelope-from=mail@nicolasgoaziou.fr; helo=relay8-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/16 05:54:57 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org-mode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: zkbTYRcplxGm Hello, "numbchild@gmail.com" writes: > With this patch, ol-man.el link type can be a link like this: > ```org > [[man:grep::--extended-regexp][grep --extended-regexp]] > ``` > Occur will auto search "--extended-regexp" string in man page buffer. Thanks. > +PATH should be a topic that can be thrown at the man command. > +If PATH contains extra ::STRING which will use `occur' to search > +matched strings in man buffer." > + (string-match "\\(.*?\\)\\(?:::\\(.*\\)\\)?$" path) > + (let* ((command (match-string 1 path)) > + (search (match-string 2 path))) > + (funcall org-man-command command) > + (with-current-buffer (concat "*Man " command "*") This should only be called if search is non-empty. > + (occur search)))) Why occur? Org uses `search-forward' for [[foo.org::text]] text links, and uses `occur' with [[foo.org::/text/]] links. Wouldn't it be more idiomatic to use a regular text search here? Regards, -- Nicolas Goaziou