From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sNdZBdYDaF+XGgAA0tVLHw (envelope-from ) for ; Mon, 21 Sep 2020 01:37:26 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id kLs/AdYDaF9SQgAA1q6Kng (envelope-from ) for ; Mon, 21 Sep 2020 01:37:26 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CA38E9404D0 for ; Mon, 21 Sep 2020 01:37:24 +0000 (UTC) Received: from localhost ([::1]:47336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKAle-0001jd-GJ for larch@yhetil.org; Sun, 20 Sep 2020 21:37:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKAlF-0001jV-Bs for emacs-orgmode@gnu.org; Sun, 20 Sep 2020 21:36:58 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:53380) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKAlB-0003xZ-IQ; Sun, 20 Sep 2020 21:36:56 -0400 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 562767E2CC; Sun, 20 Sep 2020 21:36:49 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=BZ/PSksGc4+EnB6n0b0hwYluS7w=; b=bSroYK AWT/lICEXDJCMqYt9H7cgBG9ZYoRK38ldcFA+vQfEPzrvE/A9PkIA1S229pkhvmD phUYdaXvY68ql3l21UmedsUsSkXFQK860JLwlAnMSFLC8MkOEvT6o6MuMWT+9Ozn 2i94ol21CeU5nqlbjIVWnLdTey/aWPgNkaoIc= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 4E29A7E2CB; Sun, 20 Sep 2020 21:36:49 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=27KwB+ktRHF67dAzruOcBn86I3CqtHnONaoD6IOzrZM=; b=YwBtt5/QLswR26Pj9ZXoKQyXtnx0E/EGUFlde7xEiIPx1tPvMOjgc2GhmbSKsDaXiRIhEKJKIfIfDzR65ECmgClsTcwTL0CnO+ovw0Ipzmeueo35D2c+4F+bYNaOlX+KVhpDcuSI/WF+vNDnL9JpsXfiGx5beMIz19OoqAe4Fd8= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id C441C7E2CA; Sun, 20 Sep 2020 21:36:48 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: "James N. V. Cash" Subject: Re: eldoc recursion error In-Reply-To: <877dsox7i4.fsf@gmail.com> References: <87tuvtvyig.fsf@kyleam.com> <87mu1kxxzm.fsf@gmail.com> <87k0woxxb9.fsf@gmail.com> <87k0wovx1v.fsf@kyleam.com> <877dsox7i4.fsf@gmail.com> X-Woof-Bug: fixed Date: Sun, 20 Sep 2020 21:36:48 -0400 Message-ID: <87h7rrx64v.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: EAA9AECA-FBAA-11EA-B6EA-01D9BED8090B-24757444!pb-smtp1.pobox.com Received-SPF: pass client-ip=64.147.108.70; envelope-from=kyle@kyleam.com; helo=pb-smtp1.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/20 21:36:49 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bzg@gnu.org, emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=pobox.com header.s=sasl header.b=bSroYK A; dkim=fail (rsa verify failed) header.d=kyleam.com header.s=mesmtp header.b=YwBtt5/Q; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: ixo07wQUhyBQ James N. V. Cash writes: > Kyle Meyer writes: > >> Does your cider test case above break if we use >> eldoc-print-current-symbol-info without relaying the callback? That is, >> this squashed into your patch: > > My concern with using the eldoc-print-current-symbol-info is that it's > now somewhat subverting the actual eldoc documentation function -- i.e. > the invocation of org-eldoc-documentation-function now "fails" and > instead it prints out the actual documentation as a side-effect. Indeed, > applying that patch makes the eldoc for python code blocks not work > correctly. Okay. Testing with the current Emacs master branch, I saw what I thought were the expected messages, but perhaps I wasn't testing complicated enough python blocks on my end: #+begin_src python print("ok") int(1) #+end_src Either way ... > The below patch which essentially just inlines the definition of > eldoc-documentation-default, so it's not messing around with any private > variables in eldoc, although it now won't honour the documentation > strategy. It remains to be seen if that will be an issue in practice, > but if necessary we could just check the value of > eldoc-documentation-strategy and behave appropriately. ... this sounds fine to me. Lightly testing your latest patch with Emacs 27 and 28, things work on my end. Pushed (c20cb0993). Thanks.