From: Kyle Meyer <kyle@kyleam.com>
To: Jack Kamm <jackkamm@gmail.com>
Cc: emacs-orgmode@gnu.org, TEC <tecosaur@gmail.com>
Subject: Re: [PATCH] Async session eval (2nd attempt)
Date: Thu, 04 Mar 2021 00:13:31 -0500 [thread overview]
Message-ID: <87h7lrcxhg.fsf@kyleam.com> (raw)
In-Reply-To: <871rczg7bi.fsf@gmail.com>
Jack Kamm writes:
> I also have an async implementation for ob-R that's ready after this is
> merged :)
It's a bit disappointing that only one babel user has tested this out
and provided feedback, but please feel free to merge this whenever you
think it's ready.
I'm very happy to leave the babel details to you, but here are minor
comments from a quick read-through looking for things that will likely
be changed/cleaned up (either in the Org repo or the Emacs repo) if left
as is.
> Subject: [PATCH] ob-comint.el, ob-python.el: Async session evaluation
[...]
> +;; Async evaluation
For a heading comment, please use at least three semicolons.
(info "(elisp)Comment Tips")
> +
> +(defvar-local org-babel-comint-async-indicator nil
> + "Regular expression that `org-babel-comint-async-filter' scans for.
> +It should have 2 parenthesized expressions,
> +e.g. \"org_babel_async_\\(start\\|end\\|file\\)_\\(.*\\)\". The
> +first parenthesized expression determines whether the token is
> +delimiting a result block, or whether the result is in a file. If
> +delimiting a block, the second expression gives a UUID for the
> +location to insert the result. Otherwise, the result is in a tmp
> +file, and the second expression gives the file name.")
> +
> +(defvar-local org-babel-comint-async-buffers nil
> + "List of org-mode buffers to check for Babel async output results.")
s/org-mode/Org mode/ here and other spots, following
doc/Documentation_Standards.org and tree-wide cleanups like de24694f0
(Turn org-mode into Org or Org mode, 2016-08-23).
Also, you're missing two spaces between some sentences.
> +(defmacro org-babel-comint-async-delete-dangling-and-eval
> + (session-buffer &rest body)
> + "Remove dangling text in SESSION-BUFFER and evaluate BODY.
> +This is analogous to `org-babel-comint-with-output', but meant
> +for asynchronous output, and much shorter because inserting the
> +result is delegated to `org-babel-comint-async-filter'."
> + (declare (indent 1))
> + `(org-babel-comint-in-buffer ,session-buffer
> + (goto-char (process-mark (get-buffer-process (current-buffer))))
> + (delete-region (point) (point-max))
> + ,@body))
> +(def-edebug-spec org-babel-comint-async-with-output (sexp body))
Please move this edebug spec to the `declare' form (see 7dd1cfb6c,
2021-02-12).
> diff --git a/testing/lisp/test-ob-python.el b/testing/lisp/test-ob-python.el
> index a2cc7b79c..0267678cd 100644
> --- a/testing/lisp/test-ob-python.el
> +++ b/testing/lisp/test-ob-python.el
> @@ -207,6 +207,67 @@ (ert-deftest test-ob-python/session-value-sleep ()
> #+end_src"
> (org-babel-execute-src-block)))))
>
> +(ert-deftest test-ob-python/async-simple-session-output ()
> + (let ((org-babel-temporary-directory "/tmp")
Prefer `temporary-file-directory' to hard coding "/tmp".
Thanks.
next prev parent reply other threads:[~2021-03-04 5:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-25 18:54 [PATCH] Async session eval (2nd attempt) Jack Kamm
2020-10-26 2:23 ` stardiviner
2020-10-26 9:46 ` Eric S Fraga
2020-11-09 4:09 ` Kyle Meyer
2021-01-03 8:51 ` TEC
2021-02-28 22:23 ` Jack Kamm
2021-03-01 6:22 ` Timothy
2021-03-04 5:13 ` Kyle Meyer [this message]
2021-04-25 6:26 ` Timothy
2021-04-25 7:05 ` Jack Kamm
2021-04-25 12:40 ` ian martins
2021-05-18 16:18 ` Jack Kamm
2021-04-25 14:39 ` Bastien
2021-05-15 21:09 ` Bastien
2021-05-18 16:15 ` Jack Kamm
2021-05-18 16:20 ` Jack Kamm
2021-05-19 9:01 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7lrcxhg.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=emacs-orgmode@gnu.org \
--cc=jackkamm@gmail.com \
--cc=tecosaur@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).