From: Ihor Radchenko <email@example.com> To: Shiyao MA <firstname.lastname@example.org> Cc: emacs-org list <email@example.com> Subject: Re: How to hide *Org Links* buffer when insert new links? Date: Mon, 31 May 2021 20:54:27 +0800 [thread overview] Message-ID: <87h7ij12t8.fsf@localhost> (raw) In-Reply-To: <CAJQX3DyjOvbtCCvpoWkwrPnd38q4SMJBU0MJnLa_X_gkELwfeA@mail.gmail.com> [-- Attachment #1: Type: text/plain, Size: 1016 bytes --] Shiyao MA <firstname.lastname@example.org> writes: > Hi, > > When insert org links with org-insert-link, an Org Links buffer is created. > > How can I hide it? You cannot prevent it from being created. It is hard-coded. However, you should be able to prevent Emacs from showing the buffer window by modifying your display-buffer-alist: (add-to-list 'display-buffer-alist '(("Org Links" display-buffer-no-window (allow-no-window . t)))) ... except you cannot. Apparently, Org mode is being too aggressive and ignores display-buffer-alist. I do not think that it is supposed to happen. The patch fixing current aggressive behaviour and allowing the above code to work is attached. Dear All, I do not think that unconditionally setting display-buffer-alist to nil in org-no-popups macro is the right thing to do. I updated the macro using pop-up-windows setting to nil instead of completely trashing user-defined display-buffer-alist. The latter is nil by default and if not, the user should know what he/she is doing. Best, Ihor [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: 0001-Do-not-ignore-user-defined-display-buffer-alist-in-o.patch --] [-- Type: text/x-diff, Size: 2092 bytes --] From c598f0208738f16b6d00c05a7338c226d15f5d12 Mon Sep 17 00:00:00 2001 Message-Id: <email@example.com> From: Ihor Radchenko <firstname.lastname@example.org> Date: Mon, 31 May 2021 20:47:45 +0800 Subject: [PATCH] Do not ignore user-defined display-buffer-alist in org-insert-link * lisp/ol.el (org-insert-link): Handle case when *Org Links* window is not created. * lisp/org-macs.el (org-no-popups): Do not override `display-buffer-alist'. Use `pop-up-windows' instead. --- lisp/ol.el | 13 +++++++------ lisp/org-macs.el | 2 +- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/lisp/ol.el b/lisp/ol.el index a2cf872b8..ae0177695 100644 --- a/lisp/ol.el +++ b/lisp/ol.el @@ -1856,12 +1856,13 @@ (defun org-insert-link (&optional complete-file link-location description) (reverse org-stored-links) "\n"))) (goto-char (point-min))) - (let ((cw (selected-window))) - (select-window (get-buffer-window "*Org Links*" 'visible)) - (with-current-buffer "*Org Links*" (setq truncate-lines t)) - (unless (pos-visible-in-window-p (point-max)) - (org-fit-window-to-buffer)) - (and (window-live-p cw) (select-window cw))) + (when (get-buffer-window "*Org Links*" 'visible) + (let ((cw (selected-window))) + (select-window (get-buffer-window "*Org Links*" 'visible)) + (with-current-buffer "*Org Links*" (setq truncate-lines t)) + (unless (pos-visible-in-window-p (point-max)) + (org-fit-window-to-buffer)) + (and (window-live-p cw) (select-window cw)))) (setq all-prefixes (append (mapcar #'car abbrevs) (mapcar #'car org-link-abbrev-alist) (org-link-types))) diff --git a/lisp/org-macs.el b/lisp/org-macs.el index d56fc3bce..133960fea 100644 --- a/lisp/org-macs.el +++ b/lisp/org-macs.el @@ -170,7 +170,7 @@ (defmacro org-preserve-local-variables (&rest body) (defmacro org-no-popups (&rest body) "Suppress popup windows and evaluate BODY." - `(let (pop-up-frames display-buffer-alist) + `(let (pop-up-frames pop-up-windows) ,@body)) \f -- 2.26.3
next prev parent reply other threads:[~2021-05-31 12:50 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-16 5:23 Shiyao MA 2021-05-31 12:54 ` Ihor Radchenko [this message] 2021-09-25 16:18 ` Bastien
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87h7ij12t8.fsf@localhost \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: How to hide *Org Links* buffer when insert new links?' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).