From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id rgiJI6HF3WBiMgAAgWs5BA (envelope-from ) for ; Thu, 01 Jul 2021 15:39:45 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id CD2IHqHF3WCaNQAAbx9fmQ (envelope-from ) for ; Thu, 01 Jul 2021 13:39:45 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F0AF5BEFC for ; Thu, 1 Jul 2021 15:39:44 +0200 (CEST) Received: from localhost ([::1]:58810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lywuu-0006oo-1Y for larch@yhetil.org; Thu, 01 Jul 2021 09:39:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53750) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lywu7-0006Ww-4n for emacs-orgmode@gnu.org; Thu, 01 Jul 2021 09:38:55 -0400 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]:40823) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lywu3-0006GK-KU for emacs-orgmode@gnu.org; Thu, 01 Jul 2021 09:38:54 -0400 Received: by mail-pl1-x636.google.com with SMTP id n9so1232969plf.7 for ; Thu, 01 Jul 2021 06:38:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:message-id :date:mime-version; bh=jfx0Lg9+TLk4awaIrDvU+7DlwUlhdZhz3eUm/yihaug=; b=t3RzhamSn6FvS+8boOUc79uiGkqnyPTQJxb9ke/tyZFd3poUcN3UXy7yKZMOSFEzqr hWSCVbSuslwSCaPr9xvuOg0piUVXinq3CbjrK5tQ3UuF33bhEb3vC2wUBVsse80YjmQx Dx8aYhXBR2/drmH7uJrxF5Tegb9Sb9XdhkUZN55uXnZt7GBXA+j5/4x+bRY6dDkorRD9 8Oxrw7uoE0uwwpfDSgv9+tC0igJOqu1EHI0Ahk1RcAVtwyNaksnjLFw/Ne/xNG8vprK9 APTRJCSvKGv9YEAHwd9pGARlvUwo8QRSQCmhv94o9wi9FvgRDuxnKw25fUBh5pFAQlsz 4Ubw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:message-id:date:mime-version; bh=jfx0Lg9+TLk4awaIrDvU+7DlwUlhdZhz3eUm/yihaug=; b=s8GABi1llSvLViiIH1f0K6LnLFcEQ/pZMinSCMaotpuuQjC8pAPEYQXtJ9f7DovN9/ qoUiUMzNB4c/APHj0lKEIh9BpXewnz1r8xni6k1zzmQCWJk89EzUpZgRCeTKBIhxbC8M CzUG1Oic5pznqaGh62xmC5EzH8irGhKE/3jMgWeGrQR12geNmnOO7fXlKWqocKWqnW9b MKWpMVAjvhfdqEHzR1g9R/s+ZvnWgIQGZqIUt7Z4eqmxCn5t79iXo0jVaWok9Dl2GVXX KWIZvhL88eSimvfzPQ3sv86od89cIzOSW+RorM6xR0YPqwDo3zZ0ZO9pC8maIlQxGO5W sHKw== X-Gm-Message-State: AOAM530tyxkolS0aF8iY2dpATlMZp+SjLpsKcBNTzMzWI5wU9iLDAip5 qQ5N1IX4AeRMdWaTMshyHbY= X-Google-Smtp-Source: ABdhPJwb4fohfO/JM/VEAw9dbVn1lyf0liqPlJg4LdRil9oV/a1PUsaUgdjfPYNzizUOekm956gqfQ== X-Received: by 2002:a17:902:b692:b029:11a:fae3:ba7f with SMTP id c18-20020a170902b692b029011afae3ba7fmr37074662pls.22.1625146726998; Thu, 01 Jul 2021 06:38:46 -0700 (PDT) Received: from localhost (180-150-91-8.b4965b.per.nbn.aussiebb.net. [180.150.91.8]) by smtp.gmail.com with ESMTPSA id i18sm85216pfa.37.2021.07.01.06.38.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jul 2021 06:38:46 -0700 (PDT) References: <2077251.irdbgypaU6@bl4ckspoons> User-agent: mu4e 1.4.15; emacs 28.0.50 From: Timothy To: Jacopo De Simoi Subject: Re: [PATCH] Fix erroneous tangling of blocks In-reply-to: <2077251.irdbgypaU6@bl4ckspoons> Message-ID: <87h7hei271.fsf@gmail.com> Date: Thu, 01 Jul 2021 21:38:42 +0800 MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=tecosaur@gmail.com; helo=mail-pl1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625146785; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=jfx0Lg9+TLk4awaIrDvU+7DlwUlhdZhz3eUm/yihaug=; b=ZtVnXXXCZ9pWn9eBZfJh0WCl7GPfhMBRl80XiCrnVBbneUtWoe7yHJd/i6CNIDQlR4Madh Hn02VFKRhiV94UEBhbZtQ7LZArc9XQKMqhARyKI3bMQG8C96HvFqRZUvurNSGEfMHGKZ0l Qd2t4kBmvdQHP+XmPQGUM+MkKoY9Vpg66FbEfJlBhkIzXlTvYPduaxt+NgalKKHApQdd0V fPoos5s+jDuAzJKGerN/bYKmf19PiGZM7v1C+jRwAosCv/yp98JKesJT1bBlgAzwiG+O7k NYHl26T0F3rMmbKKEYZyzB2G48wqj5MebauaBHtHvoZUD9Ro4Yyn9kP+WKRsdA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625146785; a=rsa-sha256; cv=none; b=ZtaSp5Mik76mAGi+OjoyTp1riM4zYzIzHhV52y0k9WMwzU39vKQ21m0lAvzrDqpUHOSD5w 9k7sg5bqF2V7dZPUD6g9k9nl6Muhv8by9kaJWr0wmig0LcErt83Ld0ocCh8iBWpDNk2UNs o9kV8hm9cPXTnfYY+BGPj8D1eZjcurNlajX5rckP+pHW+NDwkUYNSVy3vkU528I1OKsTxW qvsH84W+v7K858ZLSREK9oWMkZVL9o+tts3K9+huQ93sG/TycBa2RVIix9HaEUJG67czAs VvVL0CxKb3QhDABJwj9xPEMBSeTOJ4WL8D77e51iEjlgZ+GKRBFMg3lXA3PLTA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=t3RzhamS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.12 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=t3RzhamS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: F0AF5BEFC X-Spam-Score: -3.12 X-Migadu-Scanner: scn0.migadu.com X-TUID: SqimKSY7VWAn HI Jacopo, I've just taken a look at your patch and it looks good :) glad to see you've also followed the commit message format. I hope this gets merged soon. -- Timothy p.s. Just a little note for the future: it's good if you have full sentences in the description of the changes. Jacopo De Simoi writes: > Dear All, > > Please find attached a patch (against master) which takes care of the > following issue. Assume I have a block like this > > #+begin_src sh :tangle no > This should not be tangled > #+end_src > > Then the block is correctly ignored when tangling the whole file, but > erroneously tangled (to a file named "no") when tangling is run with the > universal argument (so that only the current block should be tangled) > > This happens because the check for the "no" option is not performed when > tangling a single block. In the proposed patch I address this issue by > checking for the "no" option in the function org-babel-effective-tangled- > filename