From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iN7NLwxJLmH3QQEAgWs5BA (envelope-from ) for ; Tue, 31 Aug 2021 17:21:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id EvpyKwxJLmEfZAAA1q6Kng (envelope-from ) for ; Tue, 31 Aug 2021 15:21:48 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 354D422DB1 for ; Tue, 31 Aug 2021 17:21:48 +0200 (CEST) Received: from localhost ([::1]:41148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mL5a6-0004q6-So for larch@yhetil.org; Tue, 31 Aug 2021 11:21:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54086) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mL5Z6-0004p0-7g for emacs-orgmode@gnu.org; Tue, 31 Aug 2021 11:20:44 -0400 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]:36606) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mL5Z4-0008UM-N0 for emacs-orgmode@gnu.org; Tue, 31 Aug 2021 11:20:44 -0400 Received: by mail-pj1-x1030.google.com with SMTP id u13-20020a17090abb0db0290177e1d9b3f7so2288868pjr.1 for ; Tue, 31 Aug 2021 08:20:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:references:user-agent:in-reply-to :message-id:mime-version; bh=f+iEyVJFNbBid1YlnZbRwg4xVLCEhIUE3tI2YoA1FkQ=; b=WjTFxAj6vJ+TaTTHuLW6x2JNlXC9McOxp1rKlTRxFq6iJkFFDVRzKg/Gx/JKaVDwln Z/Vup9TFJSatWhLTpPIL3qH6HbP08q6ldbKY8sbyNVxhXyxIRs+vgMKBbrxfZltLscGB /YjLz/3fcaxIGsn7wabsCJTlYXwet817F0jh3yaK59pkM3YZ0EnnO65DlNpGy/JU6qRg XqCNFAi8WwAhL/0jx+9rin16YnROeI9G5H7z+WAm5lk0wP/WjwwlXq+3A+IxFI0sJk6w Qabk1oibrOy257dzYHHg5A8H3MFDSdrBb56OQAf4a2XMGcYB2NZejzkVSqnX5VuHwhL1 xHeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:references:user-agent :in-reply-to:message-id:mime-version; bh=f+iEyVJFNbBid1YlnZbRwg4xVLCEhIUE3tI2YoA1FkQ=; b=nk+6M5Xsvibf0Z9Hcn27lVkno4JxJs3JzxE4dcja7WM2pTomj4skPoZr0Zor1nmOOI LNxuBjL74/AuWnMVqpBBZHbHsFY2EAi7v7IwEzHcSR4GzYTFWF1zqBQ/TBAH+Mp/5pfr BvG4Jy+ekIhr1dc/ssMVE3FEash1c+ZAutQ0sK8/rSTo/jTNmKEmLNLYK1/ArtEWgrb+ 0OGCIQYJLcFySANt+qSXF/Us1Vg7cmDhiXQ8s1gFkqDT9A+bScjzcoYIajxX/riHwkQX CSMib1ovZvwyQ5qlU51YwEO6tjVsFIeCs7LfeDbx5+yJz3s3c8X1wAULCLkKI8VghTG3 +oFw== X-Gm-Message-State: AOAM532z19xBOPAonGtD2NQ1W0ekPF2i9GL2fh5OGoSVohOgQBLQ3aSU Kxfb2Pdy3juxaign2vE7Bk7q6eE7mm3WyA== X-Google-Smtp-Source: ABdhPJwugzR+Y9Zgrg6TP7ooxc4jnHIPQy2oidqfjx4aU9gQH0veLq9w+PmpgK6YD2xOvozVYqynlQ== X-Received: by 2002:a17:90b:1246:: with SMTP id gx6mr6071361pjb.94.1630423240980; Tue, 31 Aug 2021 08:20:40 -0700 (PDT) Received: from localhost (61-245-128-160.3df580.per.nbn.aussiebb.net. [61.245.128.160]) by smtp.gmail.com with ESMTPSA id i14sm18109749pfd.112.2021.08.31.08.20.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 08:20:40 -0700 (PDT) From: Timothy To: Joe Corneli Subject: Re: [patch] priorities range reversed Date: Tue, 31 Aug 2021 23:14:51 +0800 References: <87v94ewyvw.fsf@Proteus> <87sfziwwso.fsf@Proteus> User-agent: mu4e 1.6.5; emacs 28.0.50 In-reply-to: <87sfziwwso.fsf@Proteus> Message-ID: <87h7f5od2y.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=tecosaur@gmail.com; helo=mail-pj1-x1030.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630423308; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=f+iEyVJFNbBid1YlnZbRwg4xVLCEhIUE3tI2YoA1FkQ=; b=I/nndZh3PE9SwEB7Jq+J3318oNG0iX48772U/v6wCg1T5QjvFh6/UliNJ1cFX1pGK+93n+ aPKCCXaUc+9PdSzN0QnHnZmDhiNBPVx03ZTjT/zoKelff5fTxgB8o3cVk1nOUJbusgR9rz VZoGN/al0bgpa/jXrpkhhf4COnse2TXMqWrIMXDJDDekUthF7Y+HhwZAv1Mq+vAQE9lVDq ZRubr1aESRP9ETVm0gq2eS9Qk0k6Rfuhy4ns+/qL0abpRdccuTpPSZUZuyZRrHTO3CPlXh egxEiwwAR2WWOFW9b7Q4r89vcxC10B4lS53qqo6yEdJndUR7P04y5M72OM7uVQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630423308; a=rsa-sha256; cv=none; b=XW9ongGJxJ0TjNgbWroUchY3dFlwDmURENEReaBn5ukparQ6B7RF7V7QorvlgkpwHhZBse ZKldqHC6Lxa15dPwG6tkPJe1/hm1Ch0TTii++WE+3LXroQ79GBnzsiWXp0PvjpErUPDn01 Zwe1fuZLAzGlYTjVSg9zwW21LdZyJDmT1H3EZMVtSdENcRa7LRz+Y0CyQlOzyMlvjHd16Z 0RKZM6LqJ9RGeICEfxZPcOANxBOlawyrD+IRiPZlVx5g9k4yO4nMfc8/cMFeerCzxUx1wu PI1E4jor6SHAUHmpoM/NhNW0Wi8bA5Ddr/izpPOb7xTxvDhPJ96Li4MrGqHwvw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=WjTFxAj6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -0.62 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=WjTFxAj6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 354D422DB1 X-Spam-Score: -0.62 X-Migadu-Scanner: scn0.migadu.com X-TUID: HzU1VUsx/zbT --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Joe, Thanks for looking into this and figuring out a patch. I=E2=80=99ve just ta= ken a peek at your patches, and I have two minor comments: =E2=81=83 Why use saved-position instead of save-excursion =E2=81=83 I=E2=80=99m think ascii versions of =E2=91=A1 et. al would be pre= ferable Also, I notice that your patches are just diffs and don=E2=80=99t have a co= mmit message. Are you planning on writing them later? Joe Corneli via =E2=80=9CGeneral discussions about Org-mode.=E2=80=9D writes: > Actually, there some bigger problems with the function as well=E2=80=A6 > > =E2=80=94 It didn=E2=80=99t update the priority cookie properly when one = had been set before > > * [#1] Exercise: update to [#2] > > =E2=80=94 After fixing that, I noticed that the included save-excursion d= oesn=E2=80=99t work > () > > So, here=E2=80=99s a more comprehensive patch, including the previous cha= nges > (in order to support numeric priorities) and then adjusting the > update/insert logic so that it makes more sense. All the best, Timothy --=-=-=--