emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Timothy <tecosaur@gmail.com>
To: Yikai Zhao <yikai@z1k.dev>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: Fontify error with markdown source block [9.4.4 (release_9.4.4 @ /usr/share/emacs/28.0.50/lisp/org/)]
Date: Fri, 17 Sep 2021 17:25:11 +0800	[thread overview]
Message-ID: <87h7ej35yq.fsf@gmail.com> (raw)
In-Reply-To: <m2tuik78nh.fsf@z1k.dev>

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

Hi Yikai,

Thanks you for reporting this bug. I was able to confirm it, and trying a few
similar such buffers can also say this only appears to affect `markdown-mode'.

I’ve prepared a patch that serves as a catch-all for this type of issue, but I’m
not sure if this is the best approach. If other people could chime in that would
be great :)

All the best,
Timothy

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-fix-potential-missing-src-match-data-issue.patch --]
[-- Type: text/x-patch, Size: 834 bytes --]

From d74d588a004b36d67c603ccbd919e07192524281 Mon Sep 17 00:00:00 2001
From: TEC <tec@tecosaur.com>
Date: Fri, 17 Sep 2021 17:23:58 +0800
Subject: [PATCH] org: fix potential missing src match-data issue

A more detailed commit message if this actually gets applied...
---
 lisp/org.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/org.el b/lisp/org.el
index c22a69154..4c630f206 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -5377,6 +5377,8 @@ (defun org-fontify-meta-lines-and-blocks-1 (limit)
 		     (min (point-max) beg-of-next-line))
 		 (min (point-max) end-of-endline))
 	       '(face org-block-end-line)))
+            (unless (match-data)
+              (set-match-data '(0 0)))
 	    t))
 	 ((member dc1 '("+title:" "+subtitle:" "+author:" "+email:" "+date:"))
 	  (org-remove-flyspell-overlays-in
-- 
2.33.0


  reply	other threads:[~2021-09-17  9:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-16 17:05 Yikai Zhao
2021-09-17  9:25 ` Timothy [this message]
2021-09-22  9:32   ` Timothy
2021-09-26  9:36   ` Bastien
2021-09-26 10:14     ` Timothy
2021-09-26 10:22       ` Bastien
2021-09-26 10:53         ` Timothy
2021-09-26 11:15           ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7ej35yq.fsf@gmail.com \
    --to=tecosaur@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=yikai@z1k.dev \
    --subject='Re: Bug: Fontify error with markdown source block [9.4.4 (release_9.4.4 @ /usr/share/emacs/28.0.50/lisp/org/)]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).