From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8JuTKwTyUWGrMAAAgWs5BA (envelope-from ) for ; Mon, 27 Sep 2021 18:32:04 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 6LLeJgTyUWESUQAAbx9fmQ (envelope-from ) for ; Mon, 27 Sep 2021 16:32:04 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E4D8C1C28C for ; Mon, 27 Sep 2021 18:32:03 +0200 (CEST) Received: from localhost ([::1]:43714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUtXu-0001Cu-Uu for larch@yhetil.org; Mon, 27 Sep 2021 12:32:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42588) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUtUc-0007Gu-IJ for emacs-orgmode@gnu.org; Mon, 27 Sep 2021 12:28:38 -0400 Received: from mail-qk1-x72a.google.com ([2607:f8b0:4864:20::72a]:37615) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUtUU-0008S7-Uj; Mon, 27 Sep 2021 12:28:37 -0400 Received: by mail-qk1-x72a.google.com with SMTP id 73so37508318qki.4; Mon, 27 Sep 2021 09:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=i7YuLVXttaVvNxlB35rDcNMwrRI8Y4cqi+cUSkl/75k=; b=nELl4xb1WzK5zLbcMumXYPWOqtg+VYZU7nZ4MVSXLy+PZ2eT7dCUgvi6jSs/claXQa gUdm9Szc7UILebRH8ORSMbKi3MbDIZaVQxc5Kd/1gVakqsnSPYOwfyymsLjAeV2RPGpR 1A0yLrvjkCwXU3gf/0Q476i4cDBYzIKTUBgRcPge4RtIlaCUYwM6wLjbdVplGmxP2q1B I5Wd5cfE85Rhn9KfjAJz0i3uyaxE17H3Mu3pWFjvNgYUl9pj+aE+ICWo9fJM2e4Pwfiy +bQ7uU/ehupVnYxPwLqqAHkBEQ+KkjS0OoSwUCHJ6CS8mwkpZCd9d/LIofZ9P/VyvxrJ 9Bjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=i7YuLVXttaVvNxlB35rDcNMwrRI8Y4cqi+cUSkl/75k=; b=2V7KmhVr9h9PyJ5bgcES2EPBeNKknrD37f2DixgtjcCM0r5UBjC4kkIxuz8ghaCELi rufga3bT7kHYMS+urVm1c49RFmRFhySHBbFOIEHq3vQTGUtwvkjquS01A7/yQRryNebB yl8PO1P5FMQntfAcIpqYFHzrQJVflrJ5AKwN9b6+JApxMJQk/CqUpCDNzX2h28uEAG2z Rp4ZuKRB1a6KBXOsfHC1qF+dkS2YG0D6T94yRbwBY8tZ0GNDcTtgH/f+WZ23y+YBqF+d RoFA2wmrBt3hz+30QIpL1j86xtmxS4tcIgvFGDGSl8OxJUeqkd+b8Be9R4mHr22zRmvg 2Nhg== X-Gm-Message-State: AOAM531MuwZ6WPKsW4fx1hgMqn8FEpCFv7/0GM6QTTiN/hXCgVn64UYx vnoaOftQNqSMCMGA1Xl5Oiw= X-Google-Smtp-Source: ABdhPJz3+07eri6vRWsqNRNEKY9SzOQbr1nNgNdvRx06/UZcj35tt81ir+yphvdNAI0HRyTUJLitgA== X-Received: by 2002:a37:64c2:: with SMTP id y185mr803352qkb.337.1632760109463; Mon, 27 Sep 2021 09:28:29 -0700 (PDT) Received: from arch ([2601:82:c200:166d:afae:ebe6:a0e2:409e]) by smtp.gmail.com with ESMTPSA id a3sm11175734qkh.67.2021.09.27.09.28.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 09:28:29 -0700 (PDT) References: <87a6l4b0bx.fsf@gmail.com> <80pmtqp2wx.fsf@felesatra.moe> <87ilzhjwkk.fsf@gmail.com> <87mtotcuf5.fsf@gmail.com> <87y28ddyby.fsf@gmail.com> <87mtnyquva.fsf@gnu.org> <87lf3idnz6.fsf@gmail.com> <87k0j23tnu.fsf@gnu.org> User-agent: mu4e 1.7.0; emacs 28.0.50 From: No Wayman To: Bastien Subject: Re: [BUG] [BUG] inconsistent behavior when reading multiple tags [9.4.6 (9.4.6-g366444 @ /home/n/.emacs.d/straight/build/org/)] Date: Mon, 27 Sep 2021 11:56:00 -0400 In-reply-to: <87k0j23tnu.fsf@gnu.org> Message-ID: <87h7e6dluc.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed Received-SPF: pass client-ip=2607:f8b0:4864:20::72a; envelope-from=iarchivedmywholelife@gmail.com; helo=mail-qk1-x72a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org, Allen Li Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632760323; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=i7YuLVXttaVvNxlB35rDcNMwrRI8Y4cqi+cUSkl/75k=; b=UA0bBse/5Mueo75cjg2XxD9ySI8B8EtJfoarBwW4bzGlPnC1A1+gqgvGwflCqzpAM5agiX xP5ML4fdpNFlFVE6tTuKI5EX676SkL0difTFmFROmAH0N8cthQ3qreuU8Fdid26BSrOR/a l0am3wtqM4suj/KiNGoDGVx44Ac2QnQIuiwQROtkMrUUc4a2aNR//Pwau+Ljox6JkseuhI exAmXO3Kw1/gWiU9hOvir/3PUFnOW3UAXsRmHs8GjD0HKSJne09lFjj4XGZMBItHwIZ8HJ yD6DrILkLm3Xg/ujYPrr/pEPayYJpI/K292G1+lZpTNc02hLCsxvNF2EHo58uA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632760323; a=rsa-sha256; cv=none; b=P8AXeUp10yJWSF2p/slSPOkiu3YAHiTGEUOB55lw6OeI3554K4bHW9kHRdjVY9qgmtjVeO x6IE2TEp82ToZ97QSQa3CmMLZjShgLrMD2noP6YmD1DtCworbNhlTmxUFLu8cBlbdsaGSn xC3ArNQhnG6iDkC89OURI8ouZYwx4Wn6DyapMEQ1mqklHfJFeV4Uq7PGokBv6g6+bZ8kc5 w0c8YkO7dizhhhLgZqvljq2A7XIsyFkZ4sXBomnoT+KQNnAgEulk6e6q62BNLTPxLbfLQ6 gkgd14/cVrLVTgMp9yl6DupbC6DkBS3mLvYDuw5b3TVOZYn1z6RtnZ8MAb+Fzw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nELl4xb1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.59 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nELl4xb1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: E4D8C1C28C X-Spam-Score: -1.59 X-Migadu-Scanner: scn0.migadu.com X-TUID: i8sGm25nAQeI Bastien writes: > Hi, > > No Wayman writes: > > Instead of a defvar that we don't want the user to modify, why > not > hardcoding the addition of the coma? I'd prefer this. `completing-read-multiple' is currently used in two spots to read tags: `org-set-tags-command' and `org-capture-fill-template'. To be clear, you would rather I hard code the same regexp and comment in those two locations rather than abstracting it into a defconst? > Any place in the manual that refers to tag separators, > explicitly or > implicitly, I've not checked if there are some. Also in the > code > itself, as a comment, to explain why both "," and ":" should be > allowed I don't see why we need to add anything to the manual. We're not changing the syntax of tags. We're utilizing the normal behavior of completing-read-multiple. The manual states for `org-set-tags-command': "By default Org mode uses the standard minibuffer completion facilities for entering tags." The comma is standard when reading multiple items. That seems to cover it to me. Another solution I proposed was indicating the delimiters in the minibuffer prompt similar to what is currently done in `org-todo-list'. e.g. org-todo-list prompt: "Keyword (or KWD1|KWD2|...): " org-set-tags-command prompt: "Tags ("," or ":" to delimit): " The only argument I heard against that was from one person who thought it "wasted space". I don't consider that a strong argument considering the length of the prompt for `org-todo-list'. >(avoid the keyboard-based argument, which is too subjective.) If one can customize their keyboard layout, I don't see why we should be so rigid about a delimiter in a prompt. It's a moot point, though, I've abandoned that proposal because it was apparently too controversial.