From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uNyLJZ4DaGFQpgAAgWs5BA (envelope-from ) for ; Thu, 14 Oct 2021 12:17:02 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 4M5DIZ4DaGEhQQAAB5/wlQ (envelope-from ) for ; Thu, 14 Oct 2021 10:17:02 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D7681198D1 for ; Thu, 14 Oct 2021 12:17:01 +0200 (CEST) Received: from localhost ([::1]:58342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maxnI-0007sn-6M for larch@yhetil.org; Thu, 14 Oct 2021 06:17:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maxlq-0007sZ-SG for emacs-orgmode@gnu.org; Thu, 14 Oct 2021 06:15:31 -0400 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:47022) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1maxln-0007qz-UJ for emacs-orgmode@gnu.org; Thu, 14 Oct 2021 06:15:30 -0400 Received: by mail-pj1-x102f.google.com with SMTP id pi19-20020a17090b1e5300b0019fdd3557d3so4387314pjb.5 for ; Thu, 14 Oct 2021 03:15:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=60iXdUo1WkY7TPYogcy9nH8V107aV6Llyq52UCOt0iY=; b=KkhEdy1NKe0Vv0jhKyXiI6h/A3xTxZOPKHuFJ2NPQJa9kwUTxoRZhuILB9s5vCzSB4 SnCd4O9tM2BIkP8Zt9Er6n6l5ctEjorg6LZCJza4FgKfX0Uxc0V+W/x0uo+L+KT/uzIu WKH1KoHCatl5SP3gl/9Y1EWCEINBXVbFMAf+4f/iRQ1z12jACFNVOqlZEyaJt4Wjr8E7 j7re58TUEnjsBYxZJORTqrDVxHOwttUciF8Vz8T08gJMWfJmPZ3X5J5O7vIAwUwRMLOZ qKe5hCUJ/fcQvxj5qM08pVl0eh+JDJIOzMgp4xskpNn2dyJv/A2nLAoLjyV1s9c2qBT7 T9Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=60iXdUo1WkY7TPYogcy9nH8V107aV6Llyq52UCOt0iY=; b=5pvp+qJt4NwL3T5IXbgk9hehGPBpXtZeOBS73EogLY8DXQidr1NAXv/dRf3dkixKwf a5wEh/sv+CoU7BocGTXuTOsTJhvjeSKvyP+GRtRRKB8DSzebPNxGFPQ98fWgfS2xknLr PHiigKyAck8FCxcxnWCbGVeNTpX06S125rbR7XuRFBT8YY+KgBN9UgRYolS7oKgsiVBE QfWtzfKgD6aVBycm/HKJjet6Q6haulX+onWbsTiWIU25YRPZubmS6wI93yr3EF3OkQ09 mc/pt6e642Iq8NXuWWMZ6am/ULk59sE6l3UvlYD375L15tFM0FSxSoEo2/EvxZzc7XQs sbrw== X-Gm-Message-State: AOAM530PWUFcfd+vRKWT7EwWdFJUv5U2YDV0rfsYGgEKSvO/T0ZvRlLN akFZ4f0yS3XUzSZWmXgwGag= X-Google-Smtp-Source: ABdhPJxwyCHOqJ0gyrSwy5Pgf/uOo1po6l54TfgJ0QrV+Il8ADT8h8pARzKP+L2g/dOuSJhePEeeYg== X-Received: by 2002:a17:90a:a609:: with SMTP id c9mr19742725pjq.134.1634206525596; Thu, 14 Oct 2021 03:15:25 -0700 (PDT) Received: from localhost ([103.125.234.161]) by smtp.gmail.com with ESMTPSA id y24sm2230346pfa.118.2021.10.14.03.15.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 03:15:24 -0700 (PDT) From: Ihor Radchenko To: Marco Wahl Subject: Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken In-Reply-To: <87fst46ifa.fsf@gmail.com> References: <87mtnovv7f.fsf@alphapapa.net> <87h7dvy70t.fsf@localhost> <87ee8zxwic.fsf@localhost> <878rz3ddet.fsf@gmail.com> <87czoaug5x.fsf@gmail.com> <87o87tso54.fsf@localhost> <87pms9mf7v.fsf@gmail.com> <878ryx14sd.fsf@ucl.ac.uk> <87fst46ifa.fsf@gmail.com> Date: Thu, 14 Oct 2021 18:16:47 +0800 Message-ID: <87h7djdi7k.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=yantar92@gmail.com; helo=mail-pj1-x102f.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org Mode List Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634206622; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=60iXdUo1WkY7TPYogcy9nH8V107aV6Llyq52UCOt0iY=; b=SEBvG2eWKbwqL87ei16jGAYbew+NSsQZ4lDd1zlZcVZLBzZkEzfyKXpNC/M1HTAcRzdjks 2yag+oYdUDojWMG5EwzIZYrg/QavyvQIATUK8gM9P/+jMz9XcZQv1sjU4xg+VRvF+tOmiH 4svWsNVK1ROcRdpoCqijV2T2lPjOT8mRK/4LSOwQBimTVjGV+/nDvJDUJohX5MRoVJUjyZ lrF1LliULKnMs7YHfnajiHJrIXJkB99Yk6GrmZc5/4+0iIRVHMIe8CAjxflCArDBjI1zDV Jr5LShKO0L+MgF0BVGf1la8taNvs6F4HgaqNAu0TK5tVlzROClUResvuXs1Duw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634206622; a=rsa-sha256; cv=none; b=r9RFH25PJW6BZ6uPkJcSUvpWPHI93PLTOvoRE8S/jWM9jbzA7UXHASkdtGiNL7vfZC7+aN E8e4P/oVgQb0/sXjQfdlZURIp/nlhwU/jp3uRdfJyWUpkR79H5lUVBJUDzxuS4ScY7Ot0I GsGedYkeDpwebsfDhuV6cRI/v7B0gwKydKoe1LbgwXj4uUjiJ0TKkTvyCQpryPl1iYlumh AxTGXi+ScGlwIAVygbuOMcAFjI4mkyLyDv287VBnNHD7pNDjuabb/8Xe5eCRIHEceSOw75 zP1W3mVAP/nUs2i/o1fUISpf0mv7sQzRdS2kc5RK3WYi2JTm/35o9LEuG7Gd+g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KkhEdy1N; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.11 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KkhEdy1N; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: D7681198D1 X-Spam-Score: -1.11 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3FRySofNJU2Y Marco Wahl writes: > Since org-goto in main is still broken I'll commit the fix for org-goto > which kicks out the use of the macro org-no-popups (but not the macro > itself since it's used elsewhere AFAICS.) > > Max, Ihor! If you see the necessity of refinement please keep going! I am inclined to think that org-no-popups may still be useful to suppress pop-up-frames. However, no so much for pop-up-windows. Note that I introduced pop-up-windows let-binding in org-no-popups in place of overriding display-buffer-alist. However, I did not fully understand pop-up-windows does and the current let-binding actually changes pop-up-windows value to nil (t is the Emacs default). I think we can simply remove pop-up-windows binding from org-no-popups. Feel free to commit this change. I am currently working on org-element-cache and do not spend much time on other patches. > BTW I think the name *Org Help* for the UI buffer could be better. Do you have better ideas? Maybe something like *Org-goto Help*? If we want to change it, we may want to do it now, before users actually use *Org Help* name i.e. in display-buffer-alist. display-buffer-alist did not affect *Org Help* before 399481bad, so we have low odds to break anybody's config yet. Best, Ihor