emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Don't quote symbols in defcustom types
@ 2022-06-14  9:28 Robert Pluim
  2022-06-14 10:12 ` Daniel Fleischer
  0 siblings, 1 reply; 9+ messages in thread
From: Robert Pluim @ 2022-06-14  9:28 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]


A couple of places in org main quoted symbols in defcustom types, but
the type itself is already quoted, so thatʼs not necessary.

Thanks

Robert
-- 

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Don-t-quote-symbols-in-defcustom-types.patch --]
[-- Type: text/x-diff, Size: 2210 bytes --]

From 3163652a7eecbf84c767c6740822e00cf842e607 Mon Sep 17 00:00:00 2001
From: Robert Pluim <rpluim@gmail.com>
Date: Mon, 13 Jun 2022 16:15:10 +0200
Subject: [PATCH] Don't quote symbols in defcustom types

* lisp/org-fold-core.el (org-fold-core-style):
* lisp/org-persist.el (org-persist-remote-files):
(org-persist-default-expiry):
Don't quote the symbol given as value for a const.
---
 lisp/org-fold-core.el | 4 ++--
 lisp/org-persist.el   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/lisp/org-fold-core.el b/lisp/org-fold-core.el
index 5dda133fb..939702c5c 100644
--- a/lisp/org-fold-core.el
+++ b/lisp/org-fold-core.el
@@ -302,8 +302,8 @@ (defcustom org-fold-core-style 'text-properties
   :group 'org
   :package-version '(Org . "9.6")
   :type '(choice
-          (const :tag "Overlays" 'overlays)
-          (const :tag "Text properties" 'text-properties)))
+          (const :tag "Overlays" overlays)
+          (cnost :tag "Text properties" text-properties)))
 
 (defvar-local org-fold-core-isearch-open-function #'org-fold-core--isearch-reveal
   "Function used to reveal hidden text found by isearch.
diff --git a/lisp/org-persist.el b/lisp/org-persist.el
index 068f58cec..ab1365220 100644
--- a/lisp/org-persist.el
+++ b/lisp/org-persist.el
@@ -196,7 +196,7 @@ (defcustom org-persist-remote-files 100
   :type '(choice (const :tag "Never" nil)
                  (const :tag "Always" t)
                  (number :tag "Keep not more than X files")
-                 (const :tag "Check if exist on remote" 'check-existence)))
+                 (const :tag "Check if exist on remote" check-existence)))
 
 (defcustom org-persist-default-expiry 30
   "Default expiry condition for persistent data.
@@ -207,7 +207,7 @@ (defcustom org-persist-default-expiry 30
 it should be a function returning non-nil when the data is expired.  The
 function will be called with a single argument - collection."
   :group 'org-persist
-  :type '(choice (const :tag "Never" 'never)
+  :type '(choice (const :tag "Never" never)
                  (const :tag "Always" nil)
                  (number :tag "Keep N days")
                  (function :tag "Function")))
-- 
2.35.1.607.gf01e51a7cf


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Don't quote symbols in defcustom types
  2022-06-14  9:28 [PATCH] Don't quote symbols in defcustom types Robert Pluim
@ 2022-06-14 10:12 ` Daniel Fleischer
  2022-06-14 10:23   ` Robert Pluim
  0 siblings, 1 reply; 9+ messages in thread
From: Daniel Fleischer @ 2022-06-14 10:12 UTC (permalink / raw)
  To: Robert Pluim; +Cc: emacs-orgmode

Robert Pluim [2022-06-14 Tue 11:28] wrote:

> A couple of places in org main quoted symbols in defcustom types, but
> the type itself is already quoted, so thatʼs not necessary.

Is it harmful though?

> -          (const :tag "Overlays" 'overlays)
> -          (const :tag "Text properties" 'text-properties)))
> +          (const :tag "Overlays" overlays)
> +          (cnost :tag "Text properties" text-properties)))

Typo here `cnost`.

-- 

Daniel Fleischer


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Don't quote symbols in defcustom types
  2022-06-14 10:12 ` Daniel Fleischer
@ 2022-06-14 10:23   ` Robert Pluim
  2022-06-14 13:06     ` Daniel Fleischer
  0 siblings, 1 reply; 9+ messages in thread
From: Robert Pluim @ 2022-06-14 10:23 UTC (permalink / raw)
  To: Daniel Fleischer; +Cc: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 836 bytes --]

>>>>> On Tue, 14 Jun 2022 13:12:54 +0300, Daniel Fleischer <danflscr@gmail.com> said:

    Daniel> Robert Pluim [2022-06-14 Tue 11:28] wrote:
    >> A couple of places in org main quoted symbols in defcustom types, but
    >> the type itself is already quoted, so thatʼs not necessary.

    Daniel> Is it harmful though?

Thereʼs the absolutist argument of "itʼs wrong!", or the practical
argument of "it causes warnings when byte compiling". Take your pick.

    >> -          (const :tag "Overlays" 'overlays)
    >> -          (const :tag "Text properties" 'text-properties)))
    >> +          (const :tag "Overlays" overlays)
    >> +          (cnost :tag "Text properties" text-properties)))

    Daniel> Typo here `cnost`.

Of course there is. Murphy and all that. Updated patch attached

Robert
-- 



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Don-t-quote-symbols-in-defcustom-types.patch --]
[-- Type: text/x-diff, Size: 2210 bytes --]

From 2c75a28bff8842f731611ebd7838c5f13122ac4d Mon Sep 17 00:00:00 2001
From: Robert Pluim <rpluim@gmail.com>
Date: Mon, 13 Jun 2022 16:15:10 +0200
Subject: [PATCH] Don't quote symbols in defcustom types

* lisp/org-fold-core.el (org-fold-core-style):
* lisp/org-persist.el (org-persist-remote-files):
(org-persist-default-expiry):
Don't quote the symbol given as value for a const.
---
 lisp/org-fold-core.el | 4 ++--
 lisp/org-persist.el   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/lisp/org-fold-core.el b/lisp/org-fold-core.el
index 5dda133fb..3ba63b725 100644
--- a/lisp/org-fold-core.el
+++ b/lisp/org-fold-core.el
@@ -302,8 +302,8 @@ (defcustom org-fold-core-style 'text-properties
   :group 'org
   :package-version '(Org . "9.6")
   :type '(choice
-          (const :tag "Overlays" 'overlays)
-          (const :tag "Text properties" 'text-properties)))
+          (const :tag "Overlays" overlays)
+          (const :tag "Text properties" text-properties)))
 
 (defvar-local org-fold-core-isearch-open-function #'org-fold-core--isearch-reveal
   "Function used to reveal hidden text found by isearch.
diff --git a/lisp/org-persist.el b/lisp/org-persist.el
index 068f58cec..ab1365220 100644
--- a/lisp/org-persist.el
+++ b/lisp/org-persist.el
@@ -196,7 +196,7 @@ (defcustom org-persist-remote-files 100
   :type '(choice (const :tag "Never" nil)
                  (const :tag "Always" t)
                  (number :tag "Keep not more than X files")
-                 (const :tag "Check if exist on remote" 'check-existence)))
+                 (const :tag "Check if exist on remote" check-existence)))
 
 (defcustom org-persist-default-expiry 30
   "Default expiry condition for persistent data.
@@ -207,7 +207,7 @@ (defcustom org-persist-default-expiry 30
 it should be a function returning non-nil when the data is expired.  The
 function will be called with a single argument - collection."
   :group 'org-persist
-  :type '(choice (const :tag "Never" 'never)
+  :type '(choice (const :tag "Never" never)
                  (const :tag "Always" nil)
                  (number :tag "Keep N days")
                  (function :tag "Function")))
-- 
2.35.1.607.gf01e51a7cf


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Don't quote symbols in defcustom types
  2022-06-14 10:23   ` Robert Pluim
@ 2022-06-14 13:06     ` Daniel Fleischer
  2022-06-14 14:04       ` Ihor Radchenko
  0 siblings, 1 reply; 9+ messages in thread
From: Daniel Fleischer @ 2022-06-14 13:06 UTC (permalink / raw)
  To: Robert Pluim; +Cc: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 49 bytes --]

Thanks for the patch, merged. 

Daniel Fleischer

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Don't quote symbols in defcustom types
  2022-06-14 13:06     ` Daniel Fleischer
@ 2022-06-14 14:04       ` Ihor Radchenko
  2022-06-14 14:13         ` Robert Pluim
  0 siblings, 1 reply; 9+ messages in thread
From: Ihor Radchenko @ 2022-06-14 14:04 UTC (permalink / raw)
  To: Daniel Fleischer; +Cc: Robert Pluim, emacs-orgmode

Daniel Fleischer <danflscr@gmail.com> writes:

> Thanks for the patch, merged. 

BTW, should it be a TINYCHANGE?

Best,
Ihor


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Don't quote symbols in defcustom types
  2022-06-14 14:04       ` Ihor Radchenko
@ 2022-06-14 14:13         ` Robert Pluim
  2022-06-14 14:19           ` Ihor Radchenko
  0 siblings, 1 reply; 9+ messages in thread
From: Robert Pluim @ 2022-06-14 14:13 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: Daniel Fleischer, emacs-orgmode

>>>>> On Tue, 14 Jun 2022 22:04:10 +0800, Ihor Radchenko <yantar92@gmail.com> said:

    Ihor> Daniel Fleischer <danflscr@gmail.com> writes:
    >> Thanks for the patch, merged. 

    Ihor> BTW, should it be a TINYCHANGE?

What's a TINYCHANGE?

Robert
-- 


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Don't quote symbols in defcustom types
  2022-06-14 14:13         ` Robert Pluim
@ 2022-06-14 14:19           ` Ihor Radchenko
  2022-06-14 14:21             ` Robert Pluim
  0 siblings, 1 reply; 9+ messages in thread
From: Ihor Radchenko @ 2022-06-14 14:19 UTC (permalink / raw)
  To: Robert Pluim; +Cc: Daniel Fleischer, emacs-orgmode

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Tue, 14 Jun 2022 22:04:10 +0800, Ihor Radchenko <yantar92@gmail.com> said:
>
>     Ihor> Daniel Fleischer <danflscr@gmail.com> writes:
>     >> Thanks for the patch, merged. 
>
>     Ihor> BTW, should it be a TINYCHANGE?
>
> What's a TINYCHANGE?

See https://orgmode.org/worg/org-contribute.html#first-patch
We need to put this word at the end of commit messages for contributors
without FSF copyright assignment.

Best,
Ihor



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Don't quote symbols in defcustom types
  2022-06-14 14:19           ` Ihor Radchenko
@ 2022-06-14 14:21             ` Robert Pluim
  2022-06-14 14:27               ` Ihor Radchenko
  0 siblings, 1 reply; 9+ messages in thread
From: Robert Pluim @ 2022-06-14 14:21 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: Daniel Fleischer, emacs-orgmode

>>>>> On Tue, 14 Jun 2022 22:19:23 +0800, Ihor Radchenko <yantar92@gmail.com> said:

    Ihor> Robert Pluim <rpluim@gmail.com> writes:
    >>>>>>> On Tue, 14 Jun 2022 22:04:10 +0800, Ihor Radchenko <yantar92@gmail.com> said:
    >> 
    Ihor> Daniel Fleischer <danflscr@gmail.com> writes:
    >> >> Thanks for the patch, merged. 
    >> 
    Ihor> BTW, should it be a TINYCHANGE?
    >> 
    >> What's a TINYCHANGE?

    Ihor> See https://orgmode.org/worg/org-contribute.html#first-patch
    Ihor> We need to put this word at the end of commit messages for contributors
    Ihor> without FSF copyright assignment.

The first patch I sent last week in <87ilp81pcx.fsf@gmail.com>
mentioned that I have assigned copyright to the FSF for Emacs.

Robert
-- 


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Don't quote symbols in defcustom types
  2022-06-14 14:21             ` Robert Pluim
@ 2022-06-14 14:27               ` Ihor Radchenko
  0 siblings, 0 replies; 9+ messages in thread
From: Ihor Radchenko @ 2022-06-14 14:27 UTC (permalink / raw)
  To: Robert Pluim; +Cc: Daniel Fleischer, emacs-orgmode

Robert Pluim <rpluim@gmail.com> writes:

>     >> What's a TINYCHANGE?
>
>     Ihor> See https://orgmode.org/worg/org-contribute.html#first-patch
>     Ihor> We need to put this word at the end of commit messages for contributors
>     Ihor> without FSF copyright assignment.
>
> The first patch I sent last week in <87ilp81pcx.fsf@gmail.com>
> mentioned that I have assigned copyright to the FSF for Emacs.

Sorry, I missed this fact when I was checking this email thread. I am
bad at remembering names and you are not yet listed in
https://orgmode.org/worg/contributors.html. Should be fixed soon.

Best,
Ihor


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-06-14 14:27 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-14  9:28 [PATCH] Don't quote symbols in defcustom types Robert Pluim
2022-06-14 10:12 ` Daniel Fleischer
2022-06-14 10:23   ` Robert Pluim
2022-06-14 13:06     ` Daniel Fleischer
2022-06-14 14:04       ` Ihor Radchenko
2022-06-14 14:13         ` Robert Pluim
2022-06-14 14:19           ` Ihor Radchenko
2022-06-14 14:21             ` Robert Pluim
2022-06-14 14:27               ` Ihor Radchenko

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).