emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Alan Wehmann <alan.wehmann@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Re: link error when file missing
Date: Mon, 11 Jul 2022 13:01:25 +0800	[thread overview]
Message-ID: <87h73oqm3e.fsf@localhost> (raw)
In-Reply-To: <874k25iax8.fsf@localhost>

Ihor Radchenko <yantar92@gmail.com> writes:

> Alan Wehmann <alan.wehmann@gmail.com> writes:
>
>> Thanks for your reply.  In my personal case I've modified "org-open-file" to throw an error for a non-existing file.  In my case, clearly Emacs is not happy with a non-existing file--at least if it is a PDF file meant to be viewed by docview.  Option 1 could have "org-docview-open" throw an error for a non-existing file, I suppose.  You describe option 2 as risking existing configs.  I am uninformed on such an issue.  I only use Org from within Emacs.  If a future problem occurs because I modified "org-open-file", I'll deal with it when it occurs.
>
> I thought more about this and I do not think that modifying
> org-open-file is a good idea. The current behaviour could be useful for
> people who would like to auto-create, say, .org/.txt files just by
> typing a link and opening it. Even .svg files could be created like
> this.
>
> So, I propose to update ol-docview instead. See the attached patch.

Applied onto main via c231e93b5.

Best,
Ihor


      parent reply	other threads:[~2022-07-11  5:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-15 14:49 Alan Wehmann
2022-04-16 12:25 ` Ihor Radchenko
     [not found]   ` <EC42A7CB-CEB6-4195-96DE-5C252CE1A29C@gmail.com>
     [not found]     ` <874k25iax8.fsf@localhost>
2022-07-11  5:01       ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h73oqm3e.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=alan.wehmann@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).