From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +N5jKbmXmWNLTwEAbAwnHQ (envelope-from ) for ; Wed, 14 Dec 2022 10:30:33 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 4JpvKbmXmWMyMgAA9RJhRA (envelope-from ) for ; Wed, 14 Dec 2022 10:30:33 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 348E8E5BE for ; Wed, 14 Dec 2022 10:30:33 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5O4w-000191-RB; Wed, 14 Dec 2022 04:29:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5O4v-00018o-GI for emacs-orgmode@gnu.org; Wed, 14 Dec 2022 04:29:29 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5O4t-0003Oj-Et for emacs-orgmode@gnu.org; Wed, 14 Dec 2022 04:29:29 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 906E2240103 for ; Wed, 14 Dec 2022 10:29:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1671010165; bh=2NgGe3UbQLWgcVDSRN7aKbeTUCTvOD50VzTQNFo6GSw=; h=From:To:Cc:Subject:Date:From; b=qyeLyE7MPuN3g+671115bZKHVr0+SPev1QtMM2avtjz0cc4xd4tgKcVjMrLO1wVSp YYdpThstp43zOXWsN5UoFSstRfYI44XWRTXRFztJSxgt99pzv9cSrs8bFxmaiocsWO paPL9hiYpA3I4S5quzaO7PT/MFuKDTPr5OE5MtDrlTxx4oPqTv3vOJMVR6tCUmI+ar gMnfabTyVZJQvqtac7ZJCuH/0BeCXOOFAgNdcsQL8YGUppwdXNiVgn8ZlguJ5rcEhs ij/9asKX/As6SqWAuP58iXYK/9xLrspEFihBNj/Z7q+lov3Lj/KUNJdlSHCXspCjm/ 65UWJG7BLYOKA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NX96r02rCz9rxB; Wed, 14 Dec 2022 10:29:23 +0100 (CET) From: Ihor Radchenko To: Pedro Andres Aranda Gutierrez Cc: Bastien , Org Mode List Subject: Re: PATCH: include controlling language= in my previous patch In-Reply-To: References: <87cz8qdzmy.fsf@localhost> <877cyxhqy1.fsf@localhost> <87bko7ejw5.fsf@localhost> <87bko7cyhy.fsf@localhost> Date: Wed, 14 Dec 2022 09:29:22 +0000 Message-ID: <87h6xyqqod.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671010233; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=2qbrqUuDNuIJdZxgpfaPdV1gIMW7fcgQ4T3lW1wLJ74=; b=lfF3TttJoeW1rINjQafyD0qvCav1YLQjuLmHj5MC4Fz0uNkcmm7f5SxrTQvLln6QgLyUc8 k5jPVSX5rP8nyFNXJM3UCv7vX/crIH7X3UQ6vTgw/qW5toU2vzft7g9OtVCLxQ4Dx1438c 9Ps5kJwFRIucUIXiJCOCnrgGve+sJM8ADGgxrp7i5jc/605gHa0w1VlMIW1tqCxvXshj14 dfOAW9IARmWSgHoVSJwEWl1ZXHmSV5zgy6M0f3t4hAMMwYX4thwP0jIg9YAo/wA+b6wXsn KpcIaHLkH0ZIKHRZmDVOn33IiROIz/gUzpO8OZJ/+GrszfapL1PKwNYdhnTU7A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=qyeLyE7M; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671010233; a=rsa-sha256; cv=none; b=eg3x/+NFFNk0cF5tQJRtrFWAceSSlzcdgX9rni73Hm+9wBuazeLyC0ptcT84SshYDM9N4A 7bHk0fJ9LgOf6hT2LQ9TLn6RN4ayjkYUgyISruHET4PeF72LLMxFPgp7IILCVlL8Qt9iIR vYnV7ciDNPvAMYW+ABkQ7qWpq5GkJJM0tkpIuciuE5khWv7z+xbP12jhL9KttvQwMon+VJ X3lnONg65H4I8P3iJqIgVU4fh/z17zRKcpLNKlQh9ze5vv4Lp6xUb4GCKaA7/FRPShrWQ9 3F77r5lhsVYmbtVPEYETCShtKY+XTNQIjG2XdFADq/XHCWsGV1Hbwjes8mXv9g== X-Migadu-Spam-Score: -4.37 X-Spam-Score: -4.37 X-Migadu-Queue-Id: 348E8E5BE X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=qyeLyE7M; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-TUID: 6CnSNZEy+Jhb Pedro Andres Aranda Gutierrez writes: > Next try... I'm learning a lot :-) Then, next set of comments. (Note that I can hand-fix the patches at this point for you. Let me know if you want to keep going) > From dabdc3026e32ec674e22698de6257d724f60c4af Mon Sep 17 00:00:00 2001 > From: "Pedro A. Aranda Gutierrez" > Date: Wed, 14 Dec 2022 07:32:31 +0100 > Subject: [PATCH 3/3] etc/ORG-NEWS: add org-latex-listings-src-omit-langua= ge ^Add `...' Also, it would make sense to merge this commit with the one introducing the variable. There is really not much reason to have two separate commits here. > * etc/ORG-NEWS: Add information for `org-latex-listings-src-omit-language' Add "." at the end of the sentence ;) Also, your Changelog entry does not include the parent heading. I recommend following https://orgmode.org/worg/org-contribute.html#org421ccec to produce changelog automatically without much thinking. > +*** New =3Dorg-latex-listings-src-omit-language=3D variable for LaTeX ex= port ~org-latex...~ also, it is new _customization_, more precisely > +The ~org-latex-listings-src-omit-language~ customization variable > +allows you to omit the =3Dlanguage=3D parameter in the exported > +=3Dlstlisting=3D environment. This is necessary when the =3Dlistings=3D By convention, we keep double space " " between sentences. > +backend delegates listing generation to another package like > +=3Dfancyvrb=3D using the following setup in the document header: > + > +#+BEGIN_src org > +,#+LATEX_HEADER: \RequirePackage{fancyvrb} > +,#+LATEX_HEADER: \DefineVerbatimEnvironment{verbatim}{Verbatim}{...whate= ver...} > +,#+LATEX_HEADER: \DefineVerbatimEnvironment{lstlisting}{Verbatim}{...wha= tever...} > +#+END_src Is there any kind of blog/article demonstrating the usefulness. Not strictly necessary, but may be helpful for others. > Subject: [PATCH 1/3] lisp/ox-latex.el: don't emit empyt label=3D, caption= =3D _D_on't; empyt -> empty > * lisp/ox-latex.el: (org-latex-src-block--listings): > Don't emit label=3D if label is empty. > DOn't emit caption=3D or captionpos=3D is caption is empty. * lisp/ox-latex.el: (org-latex-src-block--listings): -> * lisp/ox-latex.el (org-latex-src-block--listings): DOn't -> Don't is -> if > Subject: [PATCH 2/3] lisp/ox-latex.el: Add > org-latex-listings-src-omit-language `org-latex-listings-src-omit-language' > * lisp/ox-latex.el: Add org-latex-listings-src-omit-language variable `org-latex-listings-src-omit-language' > +(defcustom org-latex-listings-src-omit-language nil > + "Set this option to t to omit the > +\"language=3D\" > +in the parameters to \\begin{lstlisting} when exporting a src block. By convention, the first line of the docstring should be no wider than 67 chars and briefly describe the purpose of the variable. See D.6 Tips for Documentation Strings section of Elisp manual: =E2=80=A2 The first line of the documentation string should consist of o= ne or two complete sentences that stand on their own as a summary. =E2=80= =98M-x apropos=E2=80=99 displays just the first line, and if that line=E2=80= =99s contents don=E2=80=99t stand on their own, the result looks bad. In particular, start the first line with a capital letter and end it with a period. For a function, the first line should briefly answer the question, =E2=80=9CWhat does this function do?=E2=80=9D For a variable, the firs= t line should briefly answer the question, =E2=80=9CWhat does this value mean?=E2=80= =9D --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at