emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Ihor Radchenko <yantar92@posteo.net>
To: Nathaniel Nicandro <nathanielnicandro@gmail.com>, Bastien <bzg@gnu.org>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-user-idle-seconds: Add support for logind
Date: Wed, 22 Mar 2023 12:22:29 +0000	[thread overview]
Message-ID: <87h6udnfga.fsf@localhost> (raw)
In-Reply-To: <87a606njvc.fsf@gmail.com>

Nathaniel Nicandro <nathanielnicandro@gmail.com> writes:

> I would like to submit a patch that adds support for logind to
> `org-user-idle-seconds`.  This patch has been working for me for a long
> while now and I thought it time for me to submit it.  I've contributed
> to Emacs in the past so my paperwork should be on file.

Thanks!

Though I do not see any commits associated with Nathaniel Nicandro or
your email in Emacs git repo.
Bastien, may you check FSF records?

> Let me know if any changes should be made.
>
> lisp/org-clock.el | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)

Please provide the commit message. See
https://orgmode.org/worg/org-contribute.html#commit-messages

> +(defvar org-logind-dbus-session-path
> +  (when (and (boundp 'dbus-runtime-version)
> +             (require 'dbus nil t)
> +             (member "org.freedesktop.login1" (dbus-list-activatable-names)))
> +    (dbus-call-method
> +     :system "org.freedesktop.login1"
> +     "/org/freedesktop/login1"
> +     "org.freedesktop.login1.Manager"
> +     "GetSessionByPID" (emacs-pid))))

Please provide a docstring for the new variable.

Also, this new feature is worth documenting in ORG-NEWS.

Otherwise, the patch looks good.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

next prev parent reply	other threads:[~2023-03-22 12:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-21 15:39 [PATCH] org-user-idle-seconds: Add support for logind Nathaniel Nicandro
2023-03-22 12:22 ` Ihor Radchenko [this message]
2023-03-22 17:47   ` Bastien Guerry
2023-03-22 21:15   ` Nathaniel Nicandro
2023-03-23 11:46     ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6udnfga.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=nathanielnicandro@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).