From: Ihor Radchenko <yantar92@posteo.net>
To: Mauro Aranda <maurooaranda@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG]: No customization data for org-property-value face
Date: Sat, 15 Jul 2023 14:26:05 +0000 [thread overview]
Message-ID: <87h6q55k02.fsf@localhost> (raw)
In-Reply-To: <41956a5a-44c2-c1ea-e1e5-d018a8656e48@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 530 bytes --]
Mauro Aranda <maurooaranda@gmail.com> writes:
> After emacs -Q:
> 1. (require 'org)
> 2. M-x customize-face RET org-property-value
>
> A custom buffer shows up, but it says:
> NO CUSTOMIZATION DATA; not intended to be customized.
Thanks for reporting!
I am attaching tentative patch that makes `org-property-value' face
inherit from default face. This will preserve the existing look as Emacs
falls back to default face for "nil" faces.
Or do we want to change this face to inherit from something like
font-lock-string-face?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-property-value-Define-face-as-non-nil.patch --]
[-- Type: text/x-patch, Size: 1093 bytes --]
From 52594ea5d3e1fa5c110304fb22147713d1226198 Mon Sep 17 00:00:00 2001
Message-ID: <52594ea5d3e1fa5c110304fb22147713d1226198.1689431152.git.yantar92@posteo.net>
From: Ihor Radchenko <yantar92@posteo.net>
Date: Sat, 15 Jul 2023 17:20:54 +0300
Subject: [PATCH] org-property-value: Define face as non-nil
* lisp/org-faces.el (org-property-value): Set default value to inherit
from `font-lock-string-face' instead of using invalid face value of
nil.
Reported-by: Mauro Aranda <maurooaranda@gmail.com>
Link: https://orgmode.org/list/41956a5a-44c2-c1ea-e1e5-d018a8656e48@gmail.com
---
lisp/org-faces.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org-faces.el b/lisp/org-faces.el
index b3f8e419c..436552cb2 100644
--- a/lisp/org-faces.el
+++ b/lisp/org-faces.el
@@ -108,7 +108,7 @@ (defface org-drawer ;Copied from `font-lock-function-name-face'
"Face used for drawers."
:group 'org-faces)
-(defface org-property-value nil
+(defface org-property-value '((t :inherit default))
"Face used for the value of a property."
:group 'org-faces)
--
2.41.0
[-- Attachment #3: Type: text/plain, Size: 224 bytes --]
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-07-15 14:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-15 14:06 [BUG]: No customization data for org-property-value face Mauro Aranda
2023-07-15 14:26 ` Ihor Radchenko [this message]
2023-07-15 14:45 ` Mauro Aranda
2023-07-30 9:31 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6q55k02.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=maurooaranda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).