From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ekstrand Subject: TODO progress regression in org-mode in Emacs pretest Date: Mon, 02 Feb 2009 12:31:34 -0600 Message-ID: <87fxiwlmgp.fsf@elehack.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2045397584==" Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LU3di-0003Gs-St for emacs-orgmode@gnu.org; Mon, 02 Feb 2009 13:35:22 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LU3di-0003GR-Gq for emacs-orgmode@gnu.org; Mon, 02 Feb 2009 13:35:22 -0500 Received: from [199.232.76.173] (port=44292 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LU3di-0003GG-AD for emacs-orgmode@gnu.org; Mon, 02 Feb 2009 13:35:22 -0500 Received: from main.gmane.org ([80.91.229.2]:54835 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LU3dh-0005xI-RX for emacs-orgmode@gnu.org; Mon, 02 Feb 2009 13:35:22 -0500 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1LU3db-00029q-FE for emacs-orgmode@gnu.org; Mon, 02 Feb 2009 18:35:15 +0000 Received: from elehack.net ([216.243.177.100]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 02 Feb 2009 18:35:15 +0000 Received: from michael by elehack.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 02 Feb 2009 18:35:15 +0000 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Cc: bug-gnu-emacs@gnu.org --===============2045397584== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable I upgraded this morning from an Emacs CVS build from Jan 28 or 19 to the pretest release, and noticed a regression or undocumented change with respect to org-after-todo-statistics-hook. I am using the org-mode which is included in the pretest distribution. I have a function based on the code in section 5.5 of the Org manual to close projects when their subtasks are complete. Now, if I have a headline which does not have a subtask counter in it and toggle one of its children to DONE, my org-after-todo-statistics-hook function gets called with n-done and n-not-done values of 0. The parent headline thus has its TODO status changed. I don't think it matters too much, as my code worked before, but my hook function is `org-summary-todo' from the following. The first case of the cond is being activated. (defun mde-org-entry-is-project-p () "Query whether the current headline is a project, returning non-`nil' if it is and `nil' otherwise." (member "PROJECT" (org-get-tags-at))) ;;; Taken from Org Mode manual chapter 5.5 (defun org-summary-todo (n-done n-not-done) "Switch entry to DONE when all subentries are done, to TODO otherwise." (let ((org-log-done nil) (org-log-states nil)) (cond ((and (or (org-entry-is-todo-p) (mde-org-entry-is-project-p)) (=3D n-not-done 0)) (org-todo (if (mde-org-entry-is-project-p) "FINISHED" "DONE"))) ;; Entry is a project that is marked done ((and (mde-org-entry-is-project-p) (not (org-entry-is-todo-p)) (org-get-todo-state) (> n-not-done 0)) (org-todo 'none)) ;; Entry is a task ((and (not (mde-org-entry-is-project-p)) (not (org-entry-is-todo-p)) (org-get-todo-state) (> n-not-done 0)) (org-todo (org-get-todo-sequence-head)))))) There is a small chance that the problem was actually introduced a bit earlier, perhaps since my Jan 20 build, but I think I would have noticed it after at least the Jan 28 build. I have CC'd bug-gnu-emacs to get this in as a bug report there as well. =2D Michael =2D-=20 mouse, n: A device for pointing at the xterm in which you want to type. Confused by the strange files? I cryptographically sign my messages. For more information see . --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkmHPAYACgkQJMBfXHjb5YWUBACfVS7KPL9LKV1Fen3m9umc7qam +mgAn29LcCoeQDVZ795dBMQCity8fuzS =uaUD -----END PGP SIGNATURE----- --=-=-=-- --===============2045397584== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --===============2045397584==--