emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Dan Davison <davison@stats.ox.ac.uk>
To: emacs org-mode mailing list <emacs-orgmode@gnu.org>
Subject: new list item minor bug
Date: Sun, 27 Sep 2009 19:35:10 -0400	[thread overview]
Message-ID: <87fxa8arm9.fsf@stats.ox.ac.uk> (raw)

If you start a numbered list with

1.

and hit M-RET then you get

2. 
  ^
with a space, i.e. '2. '

However, when creating the 10th list item, there is no space after
'10.'. Same for 99 -> 100. This isn't entirely trivial, because if you
start typing blindly after hitting M-RET, then the line you have created
(lacking the space) will not be recognised as a list item and so
e.g. the next M-RET will create a new heading, not a list item. [Has
this changed recently? This seems like something obvious that others
would have noticed.]

Here's my patch.

--8<---------------cut here---------------start------------->8---
diff --git a/lisp/org-list.el b/lisp/org-list.el
index 2fea57b..8ece3ea 100644
--- a/lisp/org-list.el
+++ b/lisp/org-list.el
@@ -813,7 +813,7 @@ with something like \"1.\" or \"2)\"."
 	      (buffer-substring (point-at-bol) (match-beginning 3))))
 	;; (term (substring (match-string 3) -1))
 	ind1 (n (1- arg))
-	fmt bobp old new)
+	fmt bobp old new delta)
     ;; find where this list begins
     (org-beginning-of-item-list)
     (setq bobp (bobp))
@@ -835,7 +835,9 @@ with something like \"1.\" or \"2)\"."
 	  (delete-region (match-beginning 2) (match-end 2))
 	  (goto-char (match-beginning 2))
 	  (insert (setq new (format fmt (setq n (1+ n)))))
-	  (org-shift-item-indentation (- (length new) (length old))))))
+	  (setq delta (- (length new) (length old)))
+	  (org-shift-item-indentation delta)
+	  (if (= (org-current-line) line) (setq col (+ col delta))))))
     (org-goto-line line)
     (org-move-to-column col)))
--8<---------------cut here---------------end--------------->8---
 
Dan

next             reply	other threads:[~2009-09-27 23:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-27 23:35 Dan Davison [this message]
2009-09-27 23:41 ` new list item minor bug Dan Davison
2009-09-28  6:38 ` Carsten Dominik

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:2fea57b dfblob:8ece3ea
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fxa8arm9.fsf@stats.ox.ac.uk \
    --to=davison@stats.ox.ac.uk \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).