From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernt Hansen Subject: Re: "git describe" in version of info file with "make info_git_describe" Date: Thu, 02 Jun 2011 10:47:47 -0400 Message-ID: <87fwnse1d8.fsf@norang.ca> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:53945) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QS9Bo-0007aO-2M for emacs-orgmode@gnu.org; Thu, 02 Jun 2011 10:48:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QS9Bl-0000to-UJ for emacs-orgmode@gnu.org; Thu, 02 Jun 2011 10:47:59 -0400 Received: from mho-04-ewr.mailhop.org ([204.13.248.74]:21947 helo=mho-02-ewr.mailhop.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QS9Bl-0000t5-Dx for emacs-orgmode@gnu.org; Thu, 02 Jun 2011 10:47:57 -0400 In-Reply-To: (Michael Brand's message of "Thu, 2 Jun 2011 16:11:51 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Michael Brand Cc: Org Mode Michael Brand writes: > Hi Bernt, hi all > > I appreciate that org-version adds the output of "git describe" to the > org-version string if we are running > from a git repository. Thanks to Bernt et al: > http://thread.gmane.org/gmane.emacs.orgmode/16620 > > Now I suggest the same for the info file by using the new target "make > info_git_describe" instead of "make info" for all who are running from > a git repository and are not building a release. I am about to finish > a patch for this but before posting it would like to know the reason > for "(subst-char-in-string ?- ?. git-version t)" in org-version here: > http://orgmode.org/w/?p=org-mode.git;a=blob;f=lisp/org.el;h=1ca03f48d86fac71837079f7c3219cb295a9c795;hb=HEAD#l217 > > Can I remove this substitution of "release_7.5-350-g3433" -> > "release_7.5.350.g3433" from org-version in my patch or should "make > info_git_describe" do the same and why? Hi Michael, This was purely cosmetic. I didn't like the look of the mixed '.' and '-' in the version number originally. I think the two reported version numbers should be consistent between the org-version function and the documentation version function you are proposing. If you want to remove the substitution please also do so in the org-version code so the reported numbers are consistent. Regards, -- Bernt