emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* org-outline-regexp changes break use of org-overview in non-org buffers
@ 2011-08-12 22:06 Matt Lundin
  2011-08-15  7:52 ` Bastien
  0 siblings, 1 reply; 2+ messages in thread
From: Matt Lundin @ 2011-08-12 22:06 UTC (permalink / raw)
  To: Org Mode

The changes to org-overview in the commit
c3748fcd80ec53dc9b0db6e2ad17be6b14dd3bb9 make it impossible to use
org-global-cycle (i.e., org-overview) in non-org buffers, such as
Auctex.

The problematic line is 6231:

		 (if (re-search-forward org-outline-regexp-bol nil t)

org-outline-regexp-bol is hard-coded to match only the beginning of
outlines in org-buffers:

(defconst org-outline-regexp-bol "^\\*+ ")

The old line in org overview, by contrast, looked for the beginning of
an outline line:

		 (if (re-search-forward (concat "^" outline-regexp) nil t)

Would it be possible to revert to the older, more generous construction
of the regexp (so that it can vary by mode/buffer)?

Thanks!
Matt

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: org-outline-regexp changes break use of org-overview in non-org buffers
  2011-08-12 22:06 org-outline-regexp changes break use of org-overview in non-org buffers Matt Lundin
@ 2011-08-15  7:52 ` Bastien
  0 siblings, 0 replies; 2+ messages in thread
From: Bastien @ 2011-08-15  7:52 UTC (permalink / raw)
  To: Matt Lundin; +Cc: Org Mode

Hi Matt,

Matt Lundin <mdl@imapmail.org> writes:

> The old line in org overview, by contrast, looked for the beginning of
> an outline line:
>
> 		 (if (re-search-forward (concat "^" outline-regexp) nil t)
>
> Would it be possible to revert to the older, more generous construction
> of the regexp (so that it can vary by mode/buffer)?

Done.  Thanks for this fix, org-global-cycle now works fine in buffers
using orgstruct-mode.

-- 
 Bastien

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-08-15  7:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-12 22:06 org-outline-regexp changes break use of org-overview in non-org buffers Matt Lundin
2011-08-15  7:52 ` Bastien

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).