emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Eric Schulte <eric.schulte@gmx.com>
To: Thomas Holst <thomas.holst@de.bosch.com>
Cc: Ian Dalton <iain.dalton@gmail.com>,
	"emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: Bug: ditaa breaks export [7.8.03]
Date: Wed, 29 Feb 2012 09:30:25 -0700	[thread overview]
Message-ID: <87fwdtbo0u.fsf@gmx.com> (raw)
In-Reply-To: <ywod7gz5ervb@de.bosch.com> (Thomas Holst's message of "Wed, 29 Feb 2012 13:39:04 +0100")

Thomas Holst <thomas.holst@de.bosch.com> writes:

> Hello orgers,
>
> · Ian Dalton <iain.dalton@gmail.com> wrote:
>
>> When I run `emacs -q' and evaluate `(setq org-babel-load-languages
>> '((ditaa . t)))', then try to export an org document to PDF, after
>> answering yes to "Evaluate this ditaa code block", I get:
>>
>> Wrong type argument: stringp, nil
>>
>> Emacs  : GNU Emacs 24.0.93.1 (i486-pc-linux-gnu, GTK+ Version 2.20.1)
>>  of 2012-02-22 on cw-bkp0, modified by Debian
>> Package: Org-mode version 7.8.03
>
> I can confirm this.
>
> A little investigation shows that there are two definitions for
> `org-ditaa-jar-path':
>

Thanks for running down the cause of this problem and suggesting a fix.
I've just applied your suggestion.  The redundant definition is now
removed from ob-ditaa and ob-ditaa requires org-exp-blocks.

Cheers,

>
> - in =lisp/ob-ditaa.el=:
>   #+begin_src emacs-lisp
>     (defcustom org-ditaa-jar-path nil
>       "Path for the ditaa jar file."
>       :group 'org-babel
>       :type 'string)
>   #+end_src
>
>   This results in nil and so the error occurs.
>   
> - in =lisp/org-exp-blocks.el=
>   #+begin_src emacs-lisp
>     (defvar org-ditaa-jar-path (expand-file-name
>     			    "ditaa.jar"
>     			    (file-name-as-directory
>     			     (expand-file-name
>     			      "scripts"
>     			      (file-name-as-directory
>     			       (expand-file-name
>     				"../contrib"
>     				(file-name-directory (or load-file-name buffer-file-name)))))))
>       "Path to the ditaa jar executable.")
>   #+end_src
>
>   On my machine this results in the correct path.
>
> So the value of `org-ditaa-jar-path' depends on the loading sequence of
> el-files.
>
> A quick solution for OP would be to the set the path
>
> #+begin_src emacs-lisp
>   (setq org-ditaa-jar-path "<path-to-ditaa-jar>")
> #+end_src
>
> I am not too deep into dependencies of org files, but ob-ditaa.el could
> require org-exp-blocks and skip the definition of `org-ditaa-jar-path'.
> Or vice versa.
>
> HTH

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

     prev parent reply	other threads:[~2012-02-29 18:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-28 23:40 Bug: ditaa breaks export [7.8.03] Ian Dalton
2012-02-29 12:39 ` Thomas Holst
2012-02-29 16:30   ` Eric Schulte [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fwdtbo0u.fsf@gmx.com \
    --to=eric.schulte@gmx.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=iain.dalton@gmail.com \
    --cc=thomas.holst@de.bosch.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).