From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] org-e-latex--collect-errors Date: Sat, 15 Sep 2012 14:28:05 +0200 Message-ID: <87fw6jlbca.fsf@gmail.com> References: <20120915113429.GA6236@desktop> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:46307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCrXf-0002TD-8u for emacs-orgmode@gnu.org; Sat, 15 Sep 2012 08:32:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TCrXd-0005RQ-Ef for emacs-orgmode@gnu.org; Sat, 15 Sep 2012 08:32:11 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:45234) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCrXd-0005RG-8q for emacs-orgmode@gnu.org; Sat, 15 Sep 2012 08:32:09 -0400 Received: by wibhq4 with SMTP id hq4so717233wib.12 for ; Sat, 15 Sep 2012 05:32:08 -0700 (PDT) In-Reply-To: <20120915113429.GA6236@desktop> (Philipp Kroos's message of "Sat, 15 Sep 2012 13:34:29 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Philipp Kroos Cc: orgmode Hello, Philipp Kroos writes: > the attached patch tries to solve two issues: > - Currently, org-e-latex--collect-errors only finds errors in > pdf.*latex-logs. I removed the `pdf`, cause most of the time I'm using > xelatex which wouldn't match. I don't know if this is generic enough > for all engines though. > - Occasionally, I'm running into errors currently not matched (Like > 'Runaway argument'). What about the customizable > org-e-latex-known-errors introduced in the patch that would allow the > user to adjust the matcher to his needs and the used engine? > This also makes the code more concise. > > What do you think about this? > (The first customizable I ever wrote, I think it's correct like this, is > it?) I think this patch is good, but would you mind moving your defcustom in the appropriate section within org-e-latex.el ? Also, there are spurious blank lines in this patch. Could you remove them too? Thank you. Regards, -- Nicolas Goaziou