emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Philipp Kroos <Philipp.Kroos@t-online.de>
Cc: orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-e-latex--collect-errors
Date: Sat, 15 Sep 2012 14:28:05 +0200	[thread overview]
Message-ID: <87fw6jlbca.fsf@gmail.com> (raw)
In-Reply-To: <20120915113429.GA6236@desktop> (Philipp Kroos's message of "Sat, 15 Sep 2012 13:34:29 +0200")

Hello,

Philipp Kroos <Philipp.Kroos@t-online.de> writes:

> the attached patch tries to solve two issues:
> - Currently, org-e-latex--collect-errors only finds errors in 
>   pdf.*latex-logs. I removed the `pdf`, cause most of the time I'm using 
>   xelatex which wouldn't match. I don't know if this is generic enough 
>   for all engines though.
> - Occasionally, I'm running into errors currently not matched (Like 
>   'Runaway argument'). What about the customizable 
>   org-e-latex-known-errors introduced in the patch that would allow the 
>   user to adjust the matcher to his needs and the used engine?
>   This also makes the code more concise.
>
> What do you think about this?
> (The first customizable I ever wrote, I think it's correct like this, is 
> it?)

I think this patch is good, but would you mind moving your defcustom in
the appropriate section within org-e-latex.el ? Also, there are spurious
blank lines in this patch. Could you remove them too?

Thank you.


Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2012-09-15 12:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-15 11:34 [PATCH] org-e-latex--collect-errors Philipp Kroos
2012-09-15 12:28 ` Nicolas Goaziou [this message]
2012-09-15 13:08   ` Philipp Kroos
2012-09-15 13:23     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fw6jlbca.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=Philipp.Kroos@t-online.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).